Skip to content

Open XIOS context definition for apps#527

Open
Ed Hone (EdHone) wants to merge 3 commits into
MetOffice:mainfrom
EdHone:open-context-definition
Open

Open XIOS context definition for apps#527
Ed Hone (EdHone) wants to merge 3 commits into
MetOffice:mainfrom
EdHone:open-context-definition

Conversation

@EdHone

@EdHone Ed Hone (EdHone) commented May 29, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Sci/Tech Reviewer: Mike Hobson (@mike-hobson)
Code Reviewer: Andrew Coughtrie (@andrewcoughtrie)

Corresponding lfric_apps changes related to the de-coupling of the call to xios_close_context_definition from the lfric_xios_context_type's initialisation method. The before_close methods that are un-used have now been safely removed, and the updated interfaces have been rolled out to the apps that need them.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - lfric_apps-open-context-definition/run5

Suite Information

Item Value
Suite Name lfric_apps-open-context-definition/run5
Suite User edward.hone
Workflow Start 2026-06-02T08:42:45
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2026.03.2 True
jules MetOffice/jules@3647a42 True
lfric_apps EdHone/lfric_apps@open-context-definition False
lfric_core EdHone/lfric_core@291-context-definition True
moci MetOffice/moci@2026.03.2 True
SimSys_Scripts MetOffice/SimSys_Scripts@3e2998b True
socrates MetOffice/socrates@2026.03.2 True
socrates-spectral MetOffice/socrates-spectral@2026.03.2 True
ukca MetOffice/ukca@1cdb9c2 True

Task Information

✅ succeeded tasks - 1198

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@EdHone Ed Hone (EdHone) force-pushed the open-context-definition branch from 99bbf47 to 75c8e91 Compare June 2, 2026 08:24
@EdHone Ed Hone (EdHone) marked this pull request as ready for review June 2, 2026 12:03

@mike-hobson Mike Hobson (mike-hobson) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly just the "plumbing" part of the implementation. I can see no issues with it, but I'm not approving it, yet, as I've asked for a change on the linked Core PR and I don't want this to head off to the code reviewer before the linked PR is ready.

@DanStoneMO DanStoneMO left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested JEDI with this and it plays nicely as-is. No linked JEDI PR will be needed.

@mike-hobson Mike Hobson (mike-hobson) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked PR has now passed sci-tech review, so I'm releasing this for code review with Andrew Coughtrie (@andrewcoughtrie)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants