Open XIOS context definition for apps#527
Open
Ed Hone (EdHone) wants to merge 3 commits into
Open
Conversation
29 tasks
99bbf47 to
75c8e91
Compare
Mike Hobson (mike-hobson)
left a comment
Contributor
There was a problem hiding this comment.
This is mostly just the "plumbing" part of the implementation. I can see no issues with it, but I'm not approving it, yet, as I've asked for a change on the linked Core PR and I don't want this to head off to the code reviewer before the linked PR is ready.
DanStoneMO
approved these changes
Jun 4, 2026
DanStoneMO
left a comment
Contributor
There was a problem hiding this comment.
Tested JEDI with this and it plays nicely as-is. No linked JEDI PR will be needed.
Mike Hobson (mike-hobson)
approved these changes
Jun 5, 2026
Contributor
There was a problem hiding this comment.
The linked PR has now passed sci-tech review, so I'm releasing this for code review with Andrew Coughtrie (@andrewcoughtrie)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Mike Hobson (@mike-hobson)
Code Reviewer: Andrew Coughtrie (@andrewcoughtrie)
Corresponding lfric_apps changes related to the de-coupling of the call to
xios_close_context_definitionfrom thelfric_xios_context_type's initialisation method. Thebefore_closemethods that are un-used have now been safely removed, and the updated interfaces have been rolled out to the apps that need them.Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - lfric_apps-open-context-definition/run5
Suite Information
Task Information
✅ succeeded tasks - 1198
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review