Enable jedi_lfric to run lfric_atm forecast configurations #512
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| ############################################################################## | ||
| # (c) Crown copyright 2026 Met Office. All rights reserved. | ||
| # The file LICENCE, distributed with this code, contains details of the terms | ||
| # under which the code may be used. | ||
| ############################################################################## | ||
|
|
||
| # NOTE: Import of compile options from LFRic infrastructure is temporarily | ||
| # suspended here as a workaround for #2340 in which application of the | ||
| # -qoverride-limits option was preventing compilation of a UKCA module. | ||
| # include $(LFRIC_BUILD)/compile_options.mk | ||
|
|
||
| $(info UM physics specific compile options) | ||
|
|
||
| include $(PROJECT_DIR)/build/fortran/$(FORTRAN_COMPILER).mk | ||
|
There was a problem hiding this comment. I don't think this should be needed.
Contributor
Author
There was a problem hiding this comment. This is in the equivalent
Contributor
Author
There was a problem hiding this comment. I tired removing that but it failed during build so it appears to be needed. The failure relates to code that is now being built. This File seems to include settings that are currently required by lfric-atm. See: |
||
|
|
||
| casim/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| ukca/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| jules/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| socrates/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| legacy/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| AC_assimilation/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| aerosols/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| atmosphere_service/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| boundary_layer/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| carbon/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| convection/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| diffusion_and_filtering/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| dynamics/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| dynamics_advection/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| electric/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| free_tracers/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| gravity_wave_drag/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| idealised/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| large_scale_cloud/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| large_scale_precipitation/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| physics_diagnostics/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| PWS_diagnostics/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| radiation_control/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| stochastic_physics/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| tracer_advection/%.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) | ||
| %/limited_area_constants_mod.o: private FFLAGS_EXTRA = $(FFLAGS_INTEL_FIX_ARG) | ||
|
|
||
| $(info Disable warnings-turned-error caused by undeclared external functions - see ifort.mk) | ||
| %mpi_mod.o: private FFLAGS_EXTRA = $(FFLAGS_INTEL_EXTERNALS) | ||
| socrates/src/radiance_core/%.o: private FFLAGS_EXTRA = $(FFLAGS_INTEL_EXTERNALS) | ||
| socrates/src/interface_core/%.o: private FFLAGS_EXTRA = $(FFLAGS_INTEL_EXTERNALS) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| ############################################################################## | ||
| # (c) Crown copyright 2026 Met Office. All rights reserved. | ||
| # The file LICENCE, distributed with this code, contains details of the terms | ||
| # under which the code may be used. | ||
| ############################################################################## | ||
| # Various things specific to the Cray Fortran compiler. | ||
| ############################################################################## | ||
|
|
||
| $(info Project specials for Cray compiler) | ||
|
|
||
| export FFLAGS_UM_PHYSICS = -s real64 | ||
|
|
||
| include $(PROJECT_DIR)/build/fortran/crayftn/$(PROFILE).mk |
|
There was a problem hiding this comment. If you want to override compiler arguments on a per-file bases the
Contributor
Author
There was a problem hiding this comment. I did not and Im not sure what I need to do to test that. Can you help with this? I've been following the structure of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| ############################################################################## | ||
| # (c) Crown copyright 2026 Met Office. All rights reserved. | ||
| # The file LICENCE, distributed with this code, contains details of the terms | ||
| # under which the code may be used. | ||
| ############################################################################## | ||
| ############################################################################## | ||
| # Various things specific to fast-debug lfric_atm when using the | ||
| # Cray Fortran compiler. | ||
| # To override flags specified in LFRic Core, use | ||
| # FFLAGS_SAFE_OPTIMISATION, to add an additional flag to what is specified | ||
| # in Core, use FFLAGS_EXTRA. If you need to add debugging flags to a module, | ||
| # modify FFLAGS_DEBUG for the target module. | ||
| # All flag modification should be `private` so they are not inherited by | ||
| # submodules. | ||
| ############################################################################## | ||
|
|
||
| # ========================================================================== | ||
| # NON-DEBUG FLAGS | ||
| # ========================================================================== | ||
| # UKCA | ||
| %ukca_emiss_mode_mod.o: private FFLAGS_SAFE_OPTIMISATION = -O0 | ||
| %ukca_step_control_mod.o: private FFLAGS_SAFE_OPTIMISATION = -O0 | ||
|
|
||
| # UM | ||
| %parcel_ascent_5a.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) -hvector0 | ||
|
|
||
| # LFRic Apps | ||
| %aerosol_ukca_alg_mod_psy.o: private FFLAGS_SAFE_OPTIMISATION = -O0 | ||
| %bl_exp_alg_mod_psy.o: private FFLAGS_SAFE_OPTIMISATION = -O0 | ||
| %bl_imp_alg_mod_psy.o: private FFLAGS_SAFE_OPTIMISATION = -O0 | ||
| %conv_comorph_alg_mod_psy.o: private FFLAGS_SAFE_OPTIMISATION = -O0 | ||
| %conv_comorph_kernel_mod.o: private FFLAGS_SAFE_OPTIMISATION = -O0 | ||
| %conv_gr_alg_mod_psy.o: private FFLAGS_SAFE_OPTIMISATION = -O0 | ||
| %gungho_model_mod.o: private FFLAGS_SAFE_OPTIMISATION = -O0 | ||
| %init_aerosol_fields_alg_mod_psy.o: private FFLAGS_SAFE_OPTIMISATION = -O0 | ||
| %jules_extra_kernel_mod.o: private FFLAGS_SAFE_OPTIMISATION = -O0 | ||
| large_scale_precipitation/%.o: private FFLAGS_SAFE_OPTIMISATION = -O2 -hfp0 -hflex_mp=strict | ||
|
|
||
| # ========================================================================== | ||
| # DEBUG FLAGS | ||
| # ========================================================================== | ||
| # UKCA | ||
| %ukca_emiss_mode_mod.o: private FFLAGS_DEBUG = -G0 | ||
| %ukca_step_control_mod.o: private FFLAGS_DEBUG = -G0 | ||
|
|
||
| # LFRic Apps | ||
| %aerosol_ukca_alg_mod_psy.o: private FFLAGS_DEBUG = -G0 | ||
| %bl_exp_alg_mod_psy.o: private FFLAGS_DEBUG = -G0 | ||
| %bl_imp_alg_mod_psy.o: private FFLAGS_DEBUG = -G0 | ||
| %conv_comorph_alg_mod_psy.o: private FFLAGS_DEBUG = -G0 | ||
| %conv_comorph_kernel_mod.o: private FFLAGS_DEBUG = -G0 | ||
| %conv_gr_alg_mod_psy.o: private FFLAGS_DEBUG = -G0 | ||
| %gungho_model_mod.o: private FFLAGS_DEBUG = -G0 | ||
| %init_aerosol_fields_alg_mod_psy.o: private FFLAGS_DEBUG = -G0 | ||
| %jules_extra_kernel_mod.o: private FFLAGS_DEBUG = -G0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| ############################################################################## | ||
| # (c) Crown copyright 2026 Met Office. All rights reserved. | ||
| # The file LICENCE, distributed with this code, contains details of the terms | ||
| # under which the code may be used. | ||
| ############################################################################## | ||
| ############################################################################## | ||
| # Various things specific to full-debug lfric_atm when using the | ||
| # Cray Fortran compiler. | ||
| ############################################################################## | ||
|
|
||
| # ========================================================================== | ||
| # NON-DEBUG FLAGS | ||
| # ========================================================================== | ||
|
|
||
| # ========================================================================== | ||
| # DEBUG FLAGS | ||
| # ========================================================================== |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| ############################################################################## | ||
| # (c) Crown copyright 2026 Met Office. All rights reserved. | ||
| # The file LICENCE, distributed with this code, contains details of the terms | ||
| # under which the code may be used. | ||
| ############################################################################## | ||
| ############################################################################## | ||
| # Various things specific to production lfric_atm when using the | ||
| # Cray Fortran compiler. | ||
| ############################################################################## | ||
|
|
||
| # ========================================================================== | ||
| # DIRECTORIES | ||
| # ========================================================================== | ||
| gravity_wave_drag/%.o: private FFLAGS_RISKY_OPTIMISATION = -O2 -hflex_mp=strict | ||
|
|
||
| # ========================================================================== | ||
| # MODULES | ||
| # ========================================================================== | ||
| # UKCA | ||
| %ukca_emiss_mode_mod.o: private FFLAGS_RISKY_OPTIMISATION = -O0 | ||
| %ukca_step_control_mod.o: private FFLAGS_RISKY_OPTIMISATION = -O0 | ||
|
|
||
| # UM | ||
| %parcel_ascent_5a.o: private FFLAGS_EXTRA = $(FFLAGS_UM_PHYSICS) -hvector0 | ||
|
|
||
| # LFRic Apps | ||
| %aerosol_ukca_alg_mod_psy.o: private FFLAGS_RISKY_OPTIMISATION = -O0 | ||
| %bl_exp_alg_mod_psy.o: private FFLAGS_RISKY_OPTIMISATION = -O0 | ||
| %bl_imp_alg_mod_psy.o: private FFLAGS_RISKY_OPTIMISATION = -O0 | ||
| %conv_comorph_alg_mod_psy.o: private FFLAGS_RISKY_OPTIMISATION = -O0 | ||
| %conv_comorph_kernel_mod.o: private FFLAGS_RISKY_OPTIMISATION = -O0 | ||
| %conv_gr_alg_mod_psy.o: private FFLAGS_RISKY_OPTIMISATION = -O0 | ||
| %gungho_model_mod.o: private FFLAGS_RISKY_OPTIMISATION = -O0 | ||
| %init_aerosol_fields_alg_mod_psy.o: private FFLAGS_RISKY_OPTIMISATION = -O0 | ||
| %jules_extra_kernel_mod.o: private FFLAGS_RISKY_OPTIMISATION = -O0 | ||
| large_scale_precipitation/%.o: private FFLAGS_SAFE_OPTIMISATION = -O3 -hipa3 -hflex_mp=conservative |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| ############################################################################## | ||
| # (c) Crown copyright 2026 Met Office. All rights reserved. | ||
| # The file LICENCE, distributed with this code, contains details of the terms | ||
| # under which the code may be used. | ||
| ############################################################################## | ||
| # Various things specific to the GNU Fortran compiler. | ||
| ############################################################################## | ||
|
|
||
| $(info Project specials for GNU compiler) | ||
|
|
||
| export FFLAGS_UM_PHYSICS = -fdefault-real-8 -fdefault-double-8 | ||
| # Most lfric_atm dependencies contain code with implicit lossy conversions and | ||
| # unused variables. | ||
| # We reset the FFLAGS_WARNINGS variable here in order to prevent | ||
| # -Werror induced build failures. | ||
| FFLAGS_WARNINGS = -Wall -Werror=character-truncation -Werror=unused-value \ | ||
| -Werror=tabs | ||
| # But, we can apply some more lfric infrastructure checking to socrates | ||
| FFLAGS_SOCRATES_WARNINGS = -Werror=unused-variable | ||
|
|
||
| science/src/socrates/%.o science/src/socrates/%.mod: private FFLAGS_EXTRA = $(FFLAGS_SOCRATES_WARNINGS) | ||
|
|
||
| # We remove bounds checking (applied by -fcheck=all) and underflow checking. The | ||
| # latter is due to regular permitting of exponents going to zero for small numbers | ||
| # to imply total extinction of radiation passing through a medium | ||
| FFLAGS_RUNTIME = -fcheck=all,no-bounds -ffpe-trap=invalid,zero,overflow | ||
|
|
||
| # The lfric_atm app defines an extra set of debug flags for | ||
| # fast-debug which are the same as the full-debug settings | ||
| # except for some platforms | ||
| ifdef CRAY_ENVIRONMENT | ||
| # On the EXZ these options are switched off for fast-debug | ||
| # due to an unexpected FPE in the NetCDF library | ||
| FFLAGS_FASTD_INIT = | ||
| FFLAGS_FASTD_RUNTIME = | ||
| else | ||
| # Otherwise, use the same as the default full-debug settings | ||
| FFLAGS_FASTD_INIT = $(FFLAGS_INIT) | ||
| FFLAGS_FASTD_RUNTIME = $(FFLAGS_RUNTIME) | ||
| endif |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
INTERNAL_DEPENDENCIESlist is provided for doing exactly this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted I've been following
lfric_atmin the minimal way possible. I'm not sure what I tried that didn't work but I think I did try to minimize what is included here. Can I clarify on your comment: do you think it should be possible to remove all of the highlighted text (131-144)? I can try that if so.