fix: Wake the digest drawer Apply up only on a real change - EXO-89484 - eXIP7.3.0.22 - #6046
Merged
Merged
Conversation
…- eXIP7.3.0.22 Apply was enabled on a freshly opened drawer and went disabled as soon as a frequency was checked. It now sleeps until the choices differ from what the server holds, then follows the server rule: an enabled frequency with no category stays refused. Unchecking everything stays a change to apply, it is how the user switches his digest off. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…-89484 - eXIP7.3.0.22 The categories of a frequency that is off don't count: checking a frequency, playing with its categories and unchecking it again is going back to the initial state, and Apply must sleep. Apply now wakes up only when the effective choices differ from what the server holds. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fix of #6027, found by functional testing of the merged US03 (together with Meeds-io/commons#773, which fixes the empty category list).
Reported: Apply was enabled on a freshly opened drawer, and went disabled as soon as a frequency was checked — the reverse of the expected behavior.
Why both symptoms had one root: the category list arrived empty (the commons#773 bug), so checking a frequency selected zero categories, which the validity rule rightly refuses. And Apply had no dirty check, so a pristine drawer was 'valid' and enabled.
Fix: the drawer snapshots what the server holds at open time; Apply wakes up only when the choices differ from it, then still follows the server rule (an enabled frequency with no category stays refused). Unchecking everything remains a change to apply — it is how the user switches his digest off, per §1 'Unchecking all switches off the option'.
With commons#773 deployed, checking a frequency proposes all categories checked (per the design) and Apply enables; reverting to the loaded state disables it again.
AI contribution
Classified N1 — human-driven, no auto-merge, author ≠ approver.