Skip to content

feat: Add my organizational units portlet - MEED-10399 - Meeds-io/MIPs#237 (#4270) - #4273

Merged
sofyenne merged 1 commit into
developfrom
merge-237
Aug 13, 2026
Merged

sofyenne merged 1 commit into
developfrom
merge-237

Conversation

@sofyenne

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the partialCIBuild Perform Partial CI Build label Aug 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

@sofyenne
sofyenne marked this pull request as ready for review August 11, 2026 11:34
@sofyenne
sofyenne requested a review from boubaker August 12, 2026 13:41
@boubaker

Copy link
Copy Markdown
Member

Review — MIP-237 (part of the core#138 · portal#1300 · social#5962 · meeds#4273 set)

Reviewed against the spec in Meeds-io/MIPs#237. Findings verified against head commit c576e8d.

No functional issue in this PR itself: the MyOrganizationalUnits portlet is added to the global myteam page with a matching one-shot LayoutUpgradePlugin (merge import mode), consistent with the sibling upgrade entries in the same file.

🟢 Nit — PR/commit title typo: "oragnizational" → "organizational" (it will land in develop history via the merge commit).

⚠️ Heads-up for the merge order: this PR set should not be merged until the 🔴 Critical ACL finding on Meeds-io/social#5962 (any authenticated user can enumerate any group's members via GET /v1/social/users?groupId=...) and the 🟠 High startup NPE on Meeds-io/core#138 are fixed — the whole set is classified N1 (socle) and requires a priori human validation by an Archi/Dev, no auto-merge.

🤖 Generated with Claude Code

@sofyenne sofyenne changed the title feat: Add my oragnizational units portlet - MEED-10399 - Meeds-io/MIPs#237 (#4270) feat: Add my organizational units portlet - MEED-10399 - Meeds-io/MIPs#237 (#4270) Aug 13, 2026
@boubaker

Copy link
Copy Markdown
Member

Re-review update — cross-PR status

Follow-up to the initial review (this PR itself is unchanged, head c576e8d):

# Blocker referenced here Status
🔴 Group-member enumeration/export ACL gap — Meeds-io/social#5962 ✅ Fixed and covered by a regression test
🟠 Startup NPE in updateGroups sync — Meeds-io/core#138 ✅ Fixed
🟠 Parent→subgroup removal cascade (MIP-237 business rule) — Meeds-io/portal#1300 ⚠️ Still open — needs the Service-layer cascade or a spec amendment before the set merges
🟢 PR title typo "oragnizational" ⚠️ Still as-is

N1 classification of the set unchanged: a priori human validation by an Archi/Dev, no auto-merge.

🤖 Generated with Claude Code

@sofyenne
sofyenne merged commit e5099af into develop Aug 13, 2026
11 checks passed
@sofyenne
sofyenne deleted the merge-237 branch August 13, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

partialCIBuild Perform Partial CI Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants