Skip to content

Settings: background and accent colours under Font size, PT Default first and default, a blurred help popup - #38

Merged
Maxaubert merged 6 commits into
mainfrom
feat/accent-colour
Sep 23, 2026
Merged

Maxaubert merged 6 commits into
mainfrom
feat/accent-colour

Conversation

@Maxaubert

@Maxaubert Maxaubert commented Sep 22, 2026 •

Copy link
Copy Markdown
Owner

Stacked on #39 (merge that first; this PR's base is its branch).

For the owner

You asked for:

  • the help popup without its shadow, with a blurred background;
  • an accent colour option that picks "the accents you see like the blue highlight effect and tab effect";
  • a background colour setting;
  • both moved "to the top of the list right under font and font size";
  • your palette as the default theme for Prism Terminal, first in the list, called PT Default.

What changed

  • Settings > Appearance > Background colour and Accent colour, directly under Font size. Each shows the theme's own colour until you pick one; then a plain Reset word (Prism's style, from Settings: picking a theme moves nothing, and Reset is a word, as in Prism #39) puts it back.
  • The background repaints the whole window, terminal included. Text, dim text and the accent are re-measured against it, so they stay readable. A light colour turns the window light.
  • The accent repaints the active tab's line, the selected row and settings page, pressed buttons and primary buttons. A colour you pick is kept as it is, and only moved when the background cannot show it.
  • PT Default is the default theme, first in the wall: your saved palette (Wombat's colours on #121212) with #FE8F34 as its accent. Anyone who never picked a theme moves to it with this update; anyone who picked one keeps theirs. The wall now leads with the app's own default (Prism's default is "follow style", so its wall is unchanged; PT Default is just one more preset there).
  • The help popup blurs the window behind it and casts no shadow (in Prism too, since it is the core's).
  • Core 0.8.0 (the new preset, and a slot so the app's own rows can sit under Font size). App 0.10.0.

Not done, say if you want them

  • The agent working indicator still follows the theme's accent, not the one you pick. Changing it is a core change and a host option, so it's your call.
  • With a picked background, the terminal's ANSI colours are still measured for readability against the theme's own background. The same goes for the character under the block cursor. Both live in the core. They only matter if the picked background is far from the theme's.

Tests

  • helpPanel asserts the blurred background (blur(6px)) and no shadow.
  • typecheck clean, lint 0 errors, unit 843 passed (new: backgroundPrefs.test.ts, a light background turning the window light with readable inks, and the accent's kept/floored rules).
  • Full e2e: all scenarios passed. The accent scenario now also covers:
    • a fresh profile wears PT Default, and it is the first card;
    • Background and Accent sit right after Font size;
    • a picked background becomes the window's ground, and Reset brings the theme's back;
    • the accent reaches the active tab's line and a pressed button.

🤖 Generated with Claude Code

@Maxaubert Maxaubert changed the title Settings: an accent colour for the window Settings: background and accent colours under Font size, and Ember as the default theme Sep 22, 2026
@Maxaubert
Maxaubert changed the base branch from main to fix/theme-card-height September 22, 2026 14:58
@Maxaubert Maxaubert changed the title Settings: background and accent colours under Font size, and Ember as the default theme Settings: background and accent colours under Font size, PT Default first and default, a blurred help popup Sep 22, 2026
@Maxaubert
Maxaubert changed the base branch from fix/theme-card-height to main September 23, 2026 02:43
Maxaubert and others added 6 commits September 23, 2026 04:44
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…h a Reset word, and Ember as the default theme

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
… the window instead of casting a shadow

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…prism, by id

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@Maxaubert
Maxaubert merged commit ddc6ef1 into main Sep 23, 2026
2 checks passed
@Maxaubert
Maxaubert deleted the feat/accent-colour branch September 23, 2026 02:46
github-actions Bot pushed a commit that referenced this pull request Sep 23, 2026
…irst and default, a blurred help popup (#38)

* feat(settings): an accent colour option for the window

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* build: 0.10.0

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* test(e2e): the pressed segment follows the picked accent too

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* feat(settings): a background colour, both colours under Font size with a Reset word, and Ember as the default theme

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* feat(settings): PT Default leads the theme wall; the help popup blurs the window instead of casting a shadow

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* test: PT Default leads the preset list; the core's fallback is still prism, by id

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Maxaubert added a commit that referenced this pull request Sep 25, 2026
…2e harness (#71) (#72)

Settings: the colour editor saves the whole setup into Custom and is a theme
pick (#8, #29); ThemeSwitchAsk registers once (#22); a hex field commits only
a changed draft (#26); the dictation key is never a key that types or a chord
the terminal owns, and a press elsewhere ends the capture (#27); the editor
takes the focus, traps Tab and hears Escape, the pencil is its own button
(#28); a finished download reads fresh state before picking the model (#30).

Release and CI: release.yml tags the built commit (#11); core-release runs
from main only (#34), waits for terminal-gate by name and its success (#38),
and opens an issue when a core change cannot be released; core-version also
requires the core version above the base's (#39).

Harness: a time limit per scenario and closeApp (#35), profiles removed after
each scenario (#36), the poll's first verdict awaited instead of 6 s (#37).

Core 0.15.3, app 0.18.3. New reviewSettings e2e and unit tests.


Claude-Session: https://claude.ai/code/session_01LJbePcRzre7AusNzPNS2Bk

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
github-actions Bot pushed a commit that referenced this pull request Sep 25, 2026
…2e harness (#71) (#72)

Settings: the colour editor saves the whole setup into Custom and is a theme
pick (#8, #29); ThemeSwitchAsk registers once (#22); a hex field commits only
a changed draft (#26); the dictation key is never a key that types or a chord
the terminal owns, and a press elsewhere ends the capture (#27); the editor
takes the focus, traps Tab and hears Escape, the pencil is its own button
(#28); a finished download reads fresh state before picking the model (#30).

Release and CI: release.yml tags the built commit (#11); core-release runs
from main only (#34), waits for terminal-gate by name and its success (#38),
and opens an issue when a core change cannot be released; core-version also
requires the core version above the base's (#39).

Harness: a time limit per scenario and closeApp (#35), profiles removed after
each scenario (#36), the poll's first verdict awaited instead of 6 s (#37).

Core 0.15.3, app 0.18.3. New reviewSettings e2e and unit tests.


Claude-Session: https://claude.ai/code/session_01LJbePcRzre7AusNzPNS2Bk

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant