Repository navigation
fix(settings): the settings page has its layout back (#20) - #21
Merged
Merged
Conversation
…out back (#20) core/ sits outside the renderer root Tailwind scans, so utilities used only by the shared settings sections were never generated. The options e2e now measures the layout instead of only checking that rows exist. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Owner
Author
|
Installed 0.1.1 on the owner's machine: exe timestamp 14:14:52 -> 17:41:46, relaunched, window up. |
Maxaubert
added a commit
that referenced
this pull request
Sep 25, 2026
- Warm shell: a stale exit removes only its own entry (#2). - A tab closed while its shell is starting kills it; no duplicate spawn (#12). - Dictation: a stop while transcribing is not heard, so one paste (#4). - Ctrl+C / Ctrl+V also match the physical key (#6). - The panel attach is keyed on the session; a cd no longer steals focus (#9, #23). - Tab chords do nothing under a question or the update window (#10). - Cells vs UTF-16: resize carry and link hit-testing via termCells (#20, #25). - Shift+Enter continuation only where an agent runs (#21). - The resume spinner stops when the spawn fails (#24). - Restore runs once under StrictMode (#31). - The terminal menu belongs to its session and goes on a tab change (#32). - A drag that never drops gives the strip back (#33). Core 0.15.2, app 0.18.2. New reviewKeys e2e, unit tests for sessions, dictation and termCells; each fails on the code before the fix. Claude-Session: https://claude.ai/code/session_01LJbePcRzre7AusNzPNS2Bk Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 25, 2026
- Warm shell: a stale exit removes only its own entry (#2). - A tab closed while its shell is starting kills it; no duplicate spawn (#12). - Dictation: a stop while transcribing is not heard, so one paste (#4). - Ctrl+C / Ctrl+V also match the physical key (#6). - The panel attach is keyed on the session; a cd no longer steals focus (#9, #23). - Tab chords do nothing under a question or the update window (#10). - Cells vs UTF-16: resize carry and link hit-testing via termCells (#20, #25). - Shift+Enter continuation only where an agent runs (#21). - The resume spinner stops when the spawn fails (#24). - Restore runs once under StrictMode (#31). - The terminal menu belongs to its session and goes on a tab change (#32). - A drag that never drops gives the strip back (#33). Core 0.15.2, app 0.18.2. New reviewKeys e2e, unit tests for sessions, dictation and termCells; each fails on the code before the fix. Claude-Session: https://claude.ai/code/session_01LJbePcRzre7AusNzPNS2Bk Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
What broke
After the settings moved into
core/(#19), Prism Terminal's Settings page lost its layout: no padding, the theme wall as 40 slivers in one row, controls jammed together (owner screenshots in #20). Prism was unaffected.Why
Tailwind scans for class names from the renderer root down.
core/is at the repo root, outside it, so a utility used ONLY incore/is never generated, with no warning. It went unnoticed while every class incore/also appeared somewhere insrc/; moving the whole settings UI into the core ended that. Prism already carries an@sourceline for the core package, which is why it was fine.Fix
One line at the top of
src/renderer/src/index.css:@source '../../../core';.So it cannot come back unseen
All 14 e2e scenarios passed over the broken page, because they asserted that rows exist and work. The
optionsscenario now MEASURES the page: a theme card's width, that the wall wraps into rows, a row's padding. Run against the broken build it failed (12px cards, 1 row, 0px padding); with the fix it passes (196px, wrapped, 10px). It also writes.e2e-shots/settings-*.png, and CLAUDE.md says to look at them after moving UI betweensrc/andcore/.Verification
typecheck clean, lint 0 errors, 369 unit tests, all 14 e2e scenarios. Screenshots of both pages checked by eye. Version 0.1.1. Installed locally (see comment).
🤖 Generated with Claude Code