-
Notifications
You must be signed in to change notification settings - Fork 39
Adding the dimension_slices query parameter and associated metadata
#481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rartino
merged 78 commits into
Materials-Consortia:develop
from
JPBergsma:JPBergsma/property_ranges
Sep 19, 2025
Merged
Changes from 10 commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
3b9cbc5
Intermediate progress writing property ranges parameter.
JPBergsma eae1679
Added metadata fields to be able to use property ranges query parameter.
JPBergsma f00b52d
Small corrections.
JPBergsma 2a0bef8
moved property ranges to single_entryendpoint query param + further r…
JPBergsma 4a00af4
Some small changes after proof reading.
JPBergsma 6905d7f
added that fields should be placed in the range dictionary.
JPBergsma d579c6e
Some more sentences that had to be moved to a new line.
JPBergsma 6792962
Update optimade.rst
JPBergsma 93ecd0b
removed unintentional changes in appendix.
JPBergsma a84c72e
Seperated property_ranges query parameter from the partial data.
JPBergsma dc11574
Merge branch 'develop' into JPBergsma/property_ranges
ml-evs 17beeef
Apply formatting suggestions from code review
ml-evs cc89029
Merge branch 'develop' into JPBergsma/property_ranges
ml-evs 6d8e24f
Apply suggestions from review
rartino 680317b
Merge branch 'develop' into JPBergsma/property_ranges
rartino f2a2799
Merge branch 'develop' into JPBergsma/property_ranges
rartino 63e3821
Minor corrections from review
rartino 0efb5e7
Merge branch 'develop' into JPBergsma/property_ranges
rartino bf7e5b4
Edit property slice definition [WIP]
rartino d029756
Edit property slice definition [WIP]
rartino 63f122f
Edit property slice definition [WIP]
rartino f863308
Edit property slice definition [WIP]
rartino a73029a
Edit property slice definition [WIP]
rartino c098e47
Improve handing of Python dependencies
rartino 4f704c1
Improve handing of Python dependencies
rartino 266545b
Improve handing of Python dependencies
rartino e562f49
Revert "Improve handing of Python dependencies"
rartino 315546a
Edit property slice definition [WIP]
rartino ce9661b
Small sentence fix
giovannipizzi 358157f
Clarifying the part on dimension names.
giovannipizzi 7e29652
Apply suggestions from review
rartino 085030d
Define the term array for OPTMADE data types
rartino b3a96a0
Fix examples for slicing assuming a trajectory cartesian_site_coordin…
rartino 6231d2a
Adjust confusing phrasing about slicing based on review comment
rartino 9f639d1
Apply suggestions from code review
giovannipizzi 46eafb5
Apply suggestions from code review
giovannipizzi 657a696
Change the format of property_slices to the syntax dim_xxx[start:stop…
rartino 919b83d
Fix in formulation for property_slices format dim_xxx[start:stop:step]
rartino a623390
Apply suggestions from review
rartino b164c09
Apply suggestions from code review
rartino 628b4da
Apply changes from review
rartino 010c348
Changes from code review
rartino 3e49e5e
Update from code review
rartino 1520533
Update from code review
rartino d7d2a81
Update from code review
rartino 3f4f3a3
Changes from code review
rartino 589ab54
Update from code review
rartino 8ddf260
Changes from code review
rartino f0f120a
Update from code review
rartino e23a5c8
Merge branch 'develop' into JPBergsma/property_ranges
rartino aa644fc
Apply suggestions from code review
ndaelman-hu ea15d1f
Update optimade.rst
gmrigna 21ca65e
Replace "array" with "list" following the discussion at the OPTIMADE …
gmrigna 2f14be9
Update optimade.rst
gmrigna fd3d2c1
Fixing RST issues and remaining array/list ambiguity
giovannipizzi 116c3ad
Fix spurious old syntax for slices
giovannipizzi 52a8827
Adding explicit discussion of valid lists
giovannipizzi ed5b790
Several textual clarifications
giovannipizzi 611174d
Update optimade.rst
giovannipizzi dd03e2d
Update optimade.rst
giovannipizzi 01a8799
Reverting one change after discussion
giovannipizzi 987590d
Renamed property_slices to dimension_slices for better clarity
giovannipizzi 731cf0a
Adding client implementation note on discovering sliceable dimensions
giovannipizzi ef816e8
Minor fixes
giovannipizzi 4b6bf5d
Update optimade.rst
giovannipizzi 293e68b
Adding comment by @rartino
giovannipizzi 70500e7
Improvement to clarify that all null values must be specified in lists.
giovannipizzi 47d8485
Update optimade.rst
gmrigna d98ab47
Update optimade.rst
gmrigna 9038665
Update list definition based on review discussions
rartino e45c523
Merge branch 'develop' into JPBergsma/property_ranges
giovannipizzi d36092f
Removing leftover lines on fix over GitHub
giovannipizzi da14ac2
Minor grammar fix
rartino d2f8644
Apply suggestions from code review
rartino 4578c0e
Add suggestion from review
rartino 18cd2e5
Merge branch 'develop' into JPBergsma/property_ranges
rartino 697b2c1
Remove trailing whitespace
rartino 310ea6e
Fix formulation based on code reivew
rartino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.