Skip to content

Fix a bug where dataset will not load if s3 prefix starts with a digit#3109

Open
chinmaymore wants to merge 1 commit into
MarquezProject:mainfrom
chinmaymore:dataset-s3-prefix-with-digit
Open

Fix a bug where dataset will not load if s3 prefix starts with a digit#3109
chinmaymore wants to merge 1 commit into
MarquezProject:mainfrom
chinmaymore:dataset-s3-prefix-with-digit

Conversation

@chinmaymore
Copy link
Copy Markdown

Problem

If a dataset s3 prefix path starts with a digit, it fails to load in Marquez.

Closes: #3108

Solution

Updated Pattern to match this case.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented May 17, 2026

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

@boring-cyborg boring-cyborg Bot added api API layer changes client/java labels May 17, 2026
Signed-off-by: Chinmay More <chinmay.s.more@gmail.com>
@chinmaymore chinmaymore force-pushed the dataset-s3-prefix-with-digit branch from 70410b2 to d23a4c2 Compare May 17, 2026 08:53
@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.18%. Comparing base (180f37b) to head (d23a4c2).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3109   +/-   ##
=========================================
  Coverage     81.18%   81.18%           
  Complexity     1506     1506           
=========================================
  Files           268      268           
  Lines          7356     7356           
  Branches        325      325           
=========================================
  Hits           5972     5972           
  Misses         1226     1226           
  Partials        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API layer changes client/java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataset does not load if s3 prefix starts with a digit

1 participant