Skip to content

Added JupyterHub session tokens in jupyter/create_session route - #8135

Merged
david-yz-liu merged 1 commit into
masterfrom
jupyterhub-session-tokens
Aug 25, 2026
Merged

Added JupyterHub session tokens in jupyter/create_session route#8135
david-yz-liu merged 1 commit into
masterfrom
jupyterhub-session-tokens

Conversation

@david-yz-liu

@david-yz-liu david-yz-liu commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

This pull request modifies the new jupyter/submit route to a separate session creation mechanism in jupyter/create_session.

The latter route now authenticates based on the JupyterHub identity token and mints a session token which it returns to the JupyterHub extension, with a 15-minute expiry window. This decouples submission and identity verification, allowing for multiple JupyterHub submissions (in quick succession) using the same identity token.

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

Comment thread app/controllers/jupyter/jupyter_submissions_controller.rb Fixed
@coveralls

coveralls commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 32891457675

Coverage increased (+0.01%) to 90.693%

Details

  • Coverage increased (+0.01%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (140 of 141 lines covered, 99.29%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
app/controllers/jupyter/jupyter_submissions_controller.rb 56 55 98.21%
Total (4 files) 141 140 99.29%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 52371
Covered Lines: 48520
Line Coverage: 92.65%
Relevant Branches: 2499
Covered Branches: 1243
Branch Coverage: 49.74%
Branches in Coverage %: Yes
Coverage Strength: 128.82 hits per line

💛 - Coveralls

@david-yz-liu
david-yz-liu force-pushed the jupyterhub-session-tokens branch from 5c4c911 to c7413be Compare August 25, 2026 19:46
Comment thread app/controllers/jupyter/jupyter_submissions_controller.rb Dismissed
@david-yz-liu
david-yz-liu merged commit d11392e into master Aug 25, 2026
13 checks passed
@david-yz-liu
david-yz-liu deleted the jupyterhub-session-tokens branch August 25, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants