Skip to content

Honor updater suspension in Create animations#4766

Open
puneetdixit200 wants to merge 1 commit into
ManimCommunity:mainfrom
puneetdixit200:fix-create-suspend-updaters-v2
Open

Honor updater suspension in Create animations#4766
puneetdixit200 wants to merge 1 commit into
ManimCommunity:mainfrom
puneetdixit200:fix-create-suspend-updaters-v2

Conversation

@puneetdixit200
Copy link
Copy Markdown

Fixes #4763

Overview: What does this pull request change?

Create and other ShowPartial animations now pass dt=0 when updating their starting-copy mobject while suspend_mobject_updating=True. The original mobject was already suspended, but the starting copy could still receive elapsed time and feed updater-applied geometry back through interpolation.

Motivation and Explanation: Why and how do your changes improve the library?

This makes Create(mobject, suspend_mobject_updating=True) honor time-based updater suspension without breaking existing side-effect updater behavior covered by graphical updater tests. A non-rendering regression compares Create on a dot with a time-based updater against the same Create on a control dot.

AI assistance was used while drafting this patch; I reviewed the diff and verified the results below.

Tests

  • UV_CACHE_DIR=/tmp/manim-4763-uv-cache UV_PROJECT_ENVIRONMENT=/tmp/manim-4763-venv uv run pytest tests/module/animation/test_creation.py::test_create_suspends_mobject_updaters -q
  • UV_CACHE_DIR=/tmp/manim-4763-uv-cache UV_PROJECT_ENVIRONMENT=/tmp/manim-4763-venv uv run pytest tests/test_graphical_units/test_updaters.py::test_UpdateSceneDuringAnimation -q
  • UV_CACHE_DIR=/tmp/manim-4763-uv-cache UV_PROJECT_ENVIRONMENT=/tmp/manim-4763-venv uv run pytest tests/module/animation/test_creation.py -q
  • UV_CACHE_DIR=/tmp/manim-4763-uv-cache UV_PROJECT_ENVIRONMENT=/tmp/manim-4763-venv uv run ruff check manim/animation/creation.py tests/module/animation/test_creation.py
  • UV_CACHE_DIR=/tmp/manim-4763-uv-cache UV_PROJECT_ENVIRONMENT=/tmp/manim-4763-venv uv run ruff format --check manim/animation/creation.py tests/module/animation/test_creation.py
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create() does not suspend Mobject updating

1 participant