Honor updater suspension in Create animations#4765
Closed
puneetdixit200 wants to merge 1 commit into
Closed
Conversation
puneetdixit200
force-pushed
the
fix-create-suspend-updaters
branch
from
2ebb594 to
9c0b23e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4763
Overview: What does this pull request change?
Createand otherShowPartialanimations no longer update their starting-copy mobject whilesuspend_mobject_updating=True. The original mobject was already suspended, but the updated starting copy could still feed updater-applied geometry back through interpolation.Motivation and Explanation: Why and how do your changes improve the library?
This makes
Create(mobject, suspend_mobject_updating=True)honor the same updater suspension contract as other animations. A non-rendering regression test comparesCreateon a dot with an updater against the sameCreateon a control dot.Tests
UV_CACHE_DIR=/tmp/manim-4763-uv-cache UV_PROJECT_ENVIRONMENT=/tmp/manim-4763-venv uv run pytest tests/module/animation/test_creation.py::test_create_suspends_mobject_updaters -qUV_CACHE_DIR=/tmp/manim-4763-uv-cache UV_PROJECT_ENVIRONMENT=/tmp/manim-4763-venv uv run pytest tests/module/animation/test_creation.py -qUV_CACHE_DIR=/tmp/manim-4763-uv-cache UV_PROJECT_ENVIRONMENT=/tmp/manim-4763-venv uv run ruff check manim/animation/creation.py tests/module/animation/test_creation.pyUV_CACHE_DIR=/tmp/manim-4763-uv-cache UV_PROJECT_ENVIRONMENT=/tmp/manim-4763-venv uv run ruff format --check manim/animation/creation.py tests/module/animation/test_creation.pygit diff --check