Refactored labeled.py file#4760
Open
GoThrones wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR refactors LabaledLine and LabeledArrow class in labeled.py file. Also adds docstring to it.
Motivation and Explanation: Why and how do your changes improve the library?
Label positioning was not good enough. Now, via this PR, users will have option of where to place the label, w.r.t the Line/Arrow. Also, the scaling wasn't working properly before. But this PR allows scaling to happen not to the label, but only to the Line/Arrow.
test_LabeledArrow was failing, because this PR modifies the scale method applicable to LabeledLine and LabeledArrow class. Therefore, a new npz file: LabeledArrow.npz has been created.
Further Information and Comments
Output of the example code in docstring, for Line and Arrow:
Reviewer Checklist