Skip to content

Allow excluding inner lines of Table#4731

Merged
chopan050 merged 13 commits into
ManimCommunity:mainfrom
leqo-c:hide_table_inner_lines
Jun 3, 2026
Merged

Allow excluding inner lines of Table#4731
chopan050 merged 13 commits into
ManimCommunity:mainfrom
leqo-c:hide_table_inner_lines

Conversation

@leqo-c
Copy link
Copy Markdown
Contributor

@leqo-c leqo-c commented May 16, 2026

Overview: What does this pull request change?

Add option to hide table inner lines.

Motivation and Explanation: Why and how do your changes improve the library?

This PR adds the possibility to hide inner rows of a table by specifying the new keyword "include_inner_lines=False".

Links to added or changed documentation pages

https://manimce--4731.org.readthedocs.build/en/4731/

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@leqo-c
Copy link
Copy Markdown
Contributor Author

leqo-c commented May 16, 2026

Hi @reviewers, some tests are failing that are unrelated to my PR (tests/test_graphical_units/test_tables.py).
I added some tests in a different file (tests/module/mobject/test_table.py) and those do not appear among the failed ones.

I apologize if this sounds unreasonable but, could you help me figure out how to make those tests pass and let the PR go through? Thanks

EDIT: Solved, was a dumb indentation error (fixed with another commit).

Copy link
Copy Markdown
Member

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! I left one comment:

Comment thread manim/utils/file_ops.py Outdated
Copy link
Copy Markdown
Member

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chopan050 chopan050 changed the title Hide table inner lines Allow excluding inner lines of Table Jun 3, 2026
@chopan050 chopan050 merged commit 1b33900 into ManimCommunity:main Jun 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants