Fix init() unable to disable autocommit once enabled#446
Open
jnMetaCode wants to merge 1 commit into
Open
Conversation
The previous code used `config.autocommit = autocommit or config.autocommit`, which means once autocommit is set to True it can never be turned off again since `False or True` evaluates to `True`. Use direct assignment so `init(autocommit=False)` works as expected. Signed-off-by: JiangNan <1394485448@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ell.init(autocommit=False)doesn't work if autocommit was previously enabled.Problem
In
configurator.py,init()uses:The
oroperator means that onceautocommitisTrue, it can never be set back toFalse:init(autocommit=True)→True or False→True✓init(autocommit=False)→False or True→True✗ (expectedFalse)Fix
Use direct assignment:
This respects the caller's explicit intent. The default value in the function signature (
autocommit: bool = True) still provides a sensible default for callers who don't specify it.Reproduction