Skip to content

fix: handle Astro managed background reader startup - #97

Merged
timeleft-- merged 1 commit into
mainfrom
codex/reader-serve-lifecycle
Sep 7, 2026
Merged

fix: handle Astro managed background reader startup#97
timeleft-- merged 1 commit into
mainfrom
codex/reader-serve-lifecycle

Conversation

@timeleft--

Copy link
Copy Markdown
Member

Astro 7 can start a managed background server in an agent environment and exit its starter successfully. fava-trails rich-view serve previously treated that exit as a startup failure even while the reader was available. It now waits for HTTP readiness after an exit of zero, reports Astro's supported status/stop commands, and preserves foreground Ctrl-C cleanup. Nonzero startup or later process failure and readiness timeout still return failure.

Validation: the frozen Python suite passes 847 tests, including six focused lifecycle regressions. A fresh synthetic Astro reader started on loopback, returned HTTP 200, and stopped through astro dev stop; status correctly reported both running and stopped states. A separate invalid Astro configuration returned CLI exit 1. Ruff and git diff --check pass.

This follows the private reader acceptance in issue #54. The five real operator sessions and the continue/revise/stop decision remain open. No canonical trail records or global runtime configuration are changed by this PR.

@timeleft-- timeleft-- changed the title Fix reader startup for Astro managed background servers fix: handle Astro managed background reader startup Sep 7, 2026

@timeleft-- timeleft-- left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent exact-head review of 9a09877 against d58f861: no actionable finding in this bounded lifecycle repair. Successful background starter exit now continues HTTP readiness checking; nonzero startup/later exit and readiness timeout remain failures, and attached-server cleanup is preserved.

Independently ran the complete frozen suite: 847 tests passed in 87.13s, including six lifecycle regressions and installed-package checks, in an isolated Python3.14.3 environment. Changed-file Ruff and diff checks pass; current GitHub required checks are all green. The author's real Astro startup/status/stop and invalid-config evidence was inspected separately; those runtime probes were author-run, not rerun by this reviewer.

Accepted for integration on native independent review evidence. This COMMENT is not a separate GitHub approval. No canonical data or live private reader state was changed during review. The five real operator sessions and continue/revise/stop decision remain open.

@timeleft--
timeleft-- merged commit f0f8a5a into main Sep 7, 2026
7 of 8 checks passed
@timeleft--
timeleft-- deleted the codex/reader-serve-lifecycle branch September 7, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant