test(gateway): document private setup and verify HTTP workflow - #96
Conversation
…ceptance-20260907
timeleft--
left a comment
There was a problem hiding this comment.
Independent exact-head review of 2d51ef3: no actionable finding. Refreshed main is f0f8a5a after reader97; this three-file guide/test delta remains unchanged and the intervening reader repair touches separate files.
The guide's commands match the supported FAVA supervisor and installed tunnel-client interfaces. Ordinary identity, administrator denial, credential separation, explicit scopes, and private loopback boundaries match the implementation. Tunnel permissions/workspace association were checked against the current official OpenAI guide: https://developers.openai.com/api/docs/guides/secure-mcp-tunnels. The four tests exercise the real ASGI HTTP protocol stack, governance, JJ storage and local Git sync, with only the external reviewer result substituted. Live provider/connected-client acceptance remains separate and is not claimed by this review.
Independent exact-head verification: 845 tests passed in 93.59s, including all four new workflow cases and installed-package coverage. Frozen environment sync, Ruff, diff checks, and current GitHub required checks pass. This count describes the tested branch, not a combined-main test run.
Accepted for parent integration on native independent review evidence. This COMMENT is not a separate GitHub approval. No live services or real records were changed; no Claude execution is claimed, and existing external-review authentication/egress limitations are preserved.
timeleft--
left a comment
There was a problem hiding this comment.
Final integrated-head independent acceptance: 8c334d6 against reader97 main f0f8a5a. No actionable integration finding.
The merge joins previously accepted PR96 head2d51ef3 and independently accepted reader97/main, with no conflicts or manual resolutions. The three-file docs/test delta is byte-equivalent by stable patch ID872985e86a0fcfaf9f16adbdce3c08735a45d77a. All four HTTP/local Git workflow tests independently pass on this final head in2.66s; frozen sync, diff checks and review worktree are clean.
The author separately reports all851 combined tests pass in90.31s, plus Ruff/frozen checks. The reviewer previously independently ran all845 original PR96 tests and all847 reader97 tests; no second identical combined full suite is claimed. CI test jobs were still running at this final-head inspection, so verify required check completion before merge.
Accepted on native independent review evidence; this COMMENT is not a separate GitHub approval. No live services or real records were changed, and no Claude review is claimed.
The dedicated private gateway is implemented, but its operator setup was undocumented and the full governed workflow lacked committed HTTP coverage. Add a portable Secure MCP Tunnel guide covering repository ownership, ordinary identity, Trust Gate configuration, tunnel initialization/diagnostics, ChatGPT discovery, restart acceptance, and deployment boundaries.
Add four real HTTP integration cases using temporary JJ repositories and a local bare Git remote. Three protocol generations exercise list-tools, discovery, missing scope validation, draft isolation, identity/admin denials, normal proposal persistence, sync, and approved readback. The fourth proves dirty-state sync refusal preserves bytes and hides private paths. Only the external LLM evaluator result is substituted; HTTP, governance, storage and VCS run normally.
Validation: all845 tests passed in91.14 seconds, including installed-wheel protocol coverage; frozen environment sync, Ruff and diff checks passed. Based on reviewed main d58f861. No runtime implementation changes. Live deployed gateway acceptance independently passed real provider approval/sync and actual connected-surface readback after restart.
Closes #65. Closes #66. Parent #67 can be reconciled after integration.