Skip to content

PW-186: Adjust list styling inside accordions #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
djanelle-mit wants to merge 4 commits into from
Closed

PW-186: Adjust list styling inside accordions #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8e6a22
Updated accordion bulleted list styling
djanelle-mit May 11, 2026
c9009c0
Tightened spacing of bullets
djanelle-mit May 11, 2026
2cfcfc0
Removed space below top level UL element
djanelle-mit May 11, 2026
cbda7d7
Incrementing style sheet version
djanelle-mit May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions web/app/themes/mitlib-parent/css/scss/partials/_accordion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,18 @@
}
}

.expandable {
ul {
li.content {

@matt-bernhardt matt-bernhardt May 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a piece of content that I can look at that has this condition? When I looked for accordion content on the network, the first thing I came across was the "How does the opt-in license work?" panel here: https://pw-186-mitlib-wp-network.pantheonsite.io/scholarly/mit-open-access/opt-in-oa-license/

These list items don't have the content class, so maybe these aren't the target. However, when I edit the DOM to add that class, some javascript on the page runs and marks them as display: none - so then I'm wondering if you're targeting a different type of content than this.

I do see that these list items don't have the rules you're declaring. when I update one of the items to carry these rules (see below, second element) then it does look a little better.

Image

I'm going to approve this, as the rules themselves don't cause any problems so if you're going after a different set of list styles than for this page, I don't want t delay this longer than I already have. If this is an example of a list that you're hoping to change, though, I think the markup you're looking for doesn't end with li.content

padding-bottom: 0rem;
padding-left: 0.5rem;
margin-left: 1rem;
}
}

div.content > ul {margin-bottom: 0;}
}

.expandable .content {
padding: 0 2em 1em 2.6em;
margin-top: 0;
Expand Down
2 changes: 1 addition & 1 deletion web/app/themes/mitlib-parent/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
Theme Name: MITlib Parent
Author: MIT Libraries
Version: 0.10
Version: 0.11
Description: The parent theme for the MIT Libraries' Pentagram-designed identity.

*/
Expand Down