Skip to content

Add Herschel-Bulkley non-Newtonian viscosity model #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasontruong2707 wants to merge 29 commits into
base: master
Choose a base branch
from

Merge branch 'master' into feature/non-newtonian-viscosity

0fcedee
Select commit
Loading
Failed to load commit list.
Open

Add Herschel-Bulkley non-Newtonian viscosity model #1298

Merge branch 'master' into feature/non-newtonian-viscosity
0fcedee
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 9, 2026 in 0s

64.84% (target 1.00%)

View this Pull Request on Codecov

64.84% (target 1.00%)

Details

Codecov Report

❌ Patch coverage is 72.90323% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.84%. Comparing base (141ff01) to head (0fcedee).

Files with missing lines Patch % Lines
src/simulation/m_re_visc.fpp 50.00% 51 Missing and 1 partial ⚠️
src/simulation/m_ibm.fpp 60.00% 9 Missing and 3 partials ⚠️
src/simulation/m_riemann_solvers.fpp 88.23% 8 Missing ⚠️
src/simulation/m_checker.fpp 30.00% 7 Missing ⚠️
src/simulation/m_data_output.fpp 87.09% 3 Missing and 1 partial ⚠️
src/simulation/m_time_steppers.fpp 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1298      +/-   ##
==========================================
- Coverage   64.90%   64.84%   -0.07%     
==========================================
  Files          72       74       +2     
  Lines       18874    19005     +131     
  Branches     1571     1579       +8     
==========================================
+ Hits        12250    12323      +73     
- Misses       5649     5702      +53     
- Partials      975      980       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov