Repository navigation
fix(plugin): correct runtime lifecycle and package edge cases - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR follows a focused code review of the new NPS 1.0 plugin infrastructure and fixes four concrete runtime inconsistencies:
DisabledafterDisableAsync()instead of letting ALC cleanup overwrite it withInstalled.dllDetails
Lifecycle
DeactivateCoreAsync(..., disabled: true)correctly producedDisabled, butUnloadContext()subsequently forced successful unloads back toInstalled. ALC cleanup now preserves the lifecycle result selected by the caller and only changes the state when unload actually requires a restart.Assembly scanning
ContractAssemblyNamescontains assembly names such asNori.Plugin.Abstractions, while the scanner compared them withPath.GetFileName(...)such asNori.Plugin.Abstractions.dll. The scanner now comparesPath.GetFileNameWithoutExtension(...).The same scanner also treated native
.dllfiles as malformed managed assemblies. Native PE libraries are valid under plugin runtime layouts, so files without CLR metadata are now skipped by the managed-reference scan while managed assemblies continue to be checked for forbidden host references.Plugin ID consistency
The manifest accepts plugin IDs up to 128 characters. The AssetServer route still rejected IDs over 64 characters, and
PluginWindowHost.GetWindowsForPlugin()used the 64-character window-ID validator. Both now follow the plugin-ID limit.Regression tests
Added coverage for:
DisabledScope
This intentionally avoids unrelated refactors and does not alter the public NPS contracts.