reconstruct eos/kap on faces for mlt/tdc

star/Makefile

@@ -98,6 +98,7 @@ SRCS := \
    private/init_model.f90 \
    private/ionization_potentials.f90 \
    private/kap_support.f90 \
+   private/mlt_tdc_face_support.f90 \
    private/magnetic_diffusion.f90 \
    private/mass_utils.f90 \
    private/mesh_adjust.f90 \

star/defaults/controls_dev.defaults

@@ -200,6 +200,25 @@
     use_TDC_enthalpy_flux_limiter = .false.
 
 
+      ! use_face_values_eos_and_kap_mlt_tdc
+      ! ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+      ! MESA interpolates primitive solver variables such as T, rho, L, and
+      ! composition, together with constructed quantities such as opacity,
+      ! pressure, and other EOS results, onto cell faces for use in MLT and
+      ! TDC. If use_face_values_eos_and_kap_mlt_tdc = .true., this option
+      ! instead reconstructs only the primitive face variables and then makes
+      ! additional EOS and opacity calls to obtain the thermodynamic quantities
+      ! corresponding to that face state. Despite the cost of the extra EOS and
+      ! opacity work, this can improve accuracy on coarse meshes, especially in
+      ! unresolved opacity bumps in pulsating envelopes, and is a potential
+      ! candidate for becoming the default mode, pending further testing.
+
+      ! ::
+
+    use_face_values_eos_and_kap_mlt_tdc = .false.
+
+
       ! include_mlt_Pturb_in_thermodynamic_gradients
       ! ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
@@ -218,6 +237,7 @@
       ! If doing velocity time_centering, include time centering in mlt. Depending on the time
       ! centering flags adopted, include_mlt_in_velocity_time_centering includes time centering
       ! for P, L, and r in geff, gradr, grada, and mlt.
+      ! Currently not supported together with ``use_face_values_eos_and_kap_mlt_tdc``.
 
       ! ::
 

star/defaults/profile_columns.list

@@ -740,6 +740,17 @@
    !Uq
    !Y_face
 
+   !mlt_tdc_T_face
+   !mlt_tdc_rho_face
+   !mlt_tdc_P_face
+   !mlt_tdc_Cp_face
+   !mlt_tdc_ChiRho_face
+   !mlt_tdc_ChiT_face
+   !mlt_tdc_grada_face
+   !mlt_tdc_opacity_face
+   !mlt_tdc_scale_height_face
+   !mlt_tdc_gradr_face
+
 !# RTI
 
    !RTI_du_diffusion_kick

star/dev_cases_TDC_Pulsation/dev_TDC_Cepheid_9M/Makefile

@@ -0,0 +1 @@
+include $(MESA_DIR)/star/work/Makefile

star/dev_cases_TDC_Pulsation/dev_TDC_Cepheid_9M/ck

@@ -0,0 +1,7 @@
+#!/usr/bin/env bash
+
+# this provides the definition of check_one
+# check_one
+source "${MESA_DIR}/star/test_suite/test_suite_helpers"
+
+check_one

star/dev_cases_TDC_Pulsation/dev_TDC_Cepheid_9M/clean

@@ -0,0 +1,4 @@
+#!/usr/bin/env bash
+
+cd make
+make clean

star/dev_cases_TDC_Pulsation/dev_TDC_Cepheid_9M/gyre.in

@@ -0,0 +1,34 @@
+&model
+  add_center = .FALSE.
+/
+
+&mode
+   l = 0
+/
+
+&osc
+   inner_bound = 'ZERO_R' ! for envelopes
+   nonadiabatic = .TRUE.
+/
+
+&rot
+/
+
+&num
+   diff_scheme = 'MAGNUS_GL2'!'COLLOC_GL2' 
+/
+
+&scan
+   grid_type = 'LINEAR'
+   freq_min = 0.5!1d-4
+   freq_max = 5.0!10.0
+   freq_min_units = 'ACOUSTIC_DELTA'
+   freq_max_units = 'ACOUSTIC_DELTA'
+   n_freq = 50
+/
+
+&grid
+   w_osc = 10
+   w_exp = 2
+   w_ctr = 10
+/