Fix git pkg build sudo regression - #345
Merged
Merged
Conversation
…nto this directory and there are no subdirectories
Owner
Author
|
@gyscos with this change it seems to work fine again. Was there any other intention in this change i am missing? |
Contributor
|
Oh sorry I didn't realize I changed that. I did not actually test git repos yet, my bad... |
Owner
Author
|
Ok, i see. No problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression caused by #214
When adding a custom Git repo subdirectory to build the directory is chmodded before build which requires sudo rights:
this readds the sudo before the chmod which was deleted in #214