Skip to content

Strengthen closed-PR search in analyze phase Step 3.4 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LuciferDono merged 2 commits into from
May 18, 2026
Merged

Strengthen closed-PR search in analyze phase Step 3.4 #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aacb2e
Strengthen closed-PR search in analyze phase
ShivamShrivastava18 May 16, 2026
b644bf8
Search both open and closed PRs by target
ShivamShrivastava18 May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion skills/contribute/references/phase-analyze.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,43 @@ Then:

3. **Identify files to modify:** List every file that will need changes, and what kind of change (new code, modified logic, new tests, updated docs).

4. **Check for related work:** Search for open and closed PRs that reference the issue. Use the bare issue number to catch all link styles (fixes, closes, resolves, refs):
4. **Check for related work — run two searches, not one.**

**a) By issue number** (catches PRs that link to this issue). Use the
bare issue number to catch all link styles (fixes, closes, resolves, refs):
```bash
gh search prs --repo <OWNER/REPO> "#<NUMBER>" --state=open
gh search prs --repo <OWNER/REPO> "#<NUMBER>" --state=closed
```

**b) By specific target** (catches prior attempts that did not link the
issue, and is essential when the issue is a tracker spanning many
sub-tasks). For each function, class, or file you listed in Step 3,
search both open and closed PRs:
```bash
# By function/symbol name
gh search prs --repo <OWNER/REPO> --state=open "<TARGET_SYMBOL>"
gh search prs --repo <OWNER/REPO> --state=closed "<TARGET_SYMBOL>"
# By file basename
gh search prs --repo <OWNER/REPO> --state=open "<TARGET_FILE_BASENAME>"
gh search prs --repo <OWNER/REPO> --state=closed "<TARGET_FILE_BASENAME>"
```
Comment thread
coderabbitai[bot] marked this conversation as resolved.

For each closed PR returned, read the closing comments
(`gh pr view <NUM> --repo <OWNER/REPO> --json comments,closedAt`).
Treat these as **BLOCKER-level risks** in the brief:
- Maintainer rejected the exact approach you are planning ("we don't
accept X", "please don't submit Y", "wrong direction").
- The target was closed as obsolete / superseded / out-of-scope.
- A merged PR already addressed the sub-task but the tracker issue is
still open.

**Why both searches matter:** a tracker issue with many sub-tasks
generates dozens of sub-PRs over time. Searching only by issue number
returns noise and misses function-specific prior attempts that did not
link the tracker. Searching by the specific function name catches those
even when the prior PR was not linked.

## Step 4: Present the Contribution Brief

Present a structured brief:
Expand Down
Loading