Skip to content

warnings: Silence default Clang warnings #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fbriere wants to merge 3 commits into
base: master
Choose a base branch
from
Open

warnings: Silence default Clang warnings #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4962603
warnings: Add parentheses around expressions [-Wparentheses]
fbriere Oct 10, 2016
aac0583
warnings: Add braces around nested if() statement [-Wdangling-else]
fbriere Oct 10, 2016
9ec79df
warnings: Silence warning about unhandled enum values [-Wswitch]
fbriere Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/audio/audio_device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ void t_oss_io::enable(bool enable_playback, bool enable_recording) {
void t_oss_io::flush(bool playback_buffer, bool recording_buffer) {
for (int i = 0; i < 2; i++) {
// i == 0: flush playback buffer, 1: flush recording buffer
if (i == 0 && playback_buffer || i == 1 && recording_buffer) {
if ((i == 0 && playback_buffer) || (i == 1 && recording_buffer)) {
int skip_bytes = ( (i==0) ? play_buffersize :
rec_buffersize) - get_buffer_space(i == 1);
if(skip_bytes <= 0) continue;
Expand Down
3 changes: 2 additions & 1 deletion src/audio/g72x.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,11 +369,12 @@ update(
/* UPA1 */
/* update predictor pole a[0] */
state_ptr->a[0] -= state_ptr->a[0] >> 8;
if (dqsez != 0)
if (dqsez != 0) {
if (pks1 == 0)
state_ptr->a[0] += 192;
else
state_ptr->a[0] -= 192;
}

/* LIMD */
a1ul = 15360 - a2p;
Expand Down
3 changes: 3 additions & 0 deletions src/dialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3919,6 +3919,9 @@ void t_dialog::timeout(t_line_timer timer) {
case LTMR_SESSION_REFRESH:
case LTMR_SESSION_EXPIRE:
return timeout_session_refresh(timer);
default:
// We're not dealing with a session timer, so carry on as usual
break;
}

switch(state) {
Expand Down
3 changes: 3 additions & 0 deletions src/parser/hdr_session_expires.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ string t_hdr_session_expires::encode_value(void) const {
case REFRESHER_UAC:
refresher_str = SE_REFRESHER_UAC;
break;
case REFRESHER_NONE:
// Leave refresher_str empty
break;
}
if (!refresher_str.empty()) {
t_parameter r("refresher", refresher_str);
Expand Down
8 changes: 4 additions & 4 deletions src/parser/response.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,10 @@ bool t_response::is_valid(bool &fatal, string &reason) const {
}

bool t_response::must_authenticate(void) const {
return (code == R_401_UNAUTHORIZED &&
hdr_www_authenticate.is_populated() ||
code == R_407_PROXY_AUTH_REQUIRED &&
hdr_proxy_authenticate.is_populated());
return ((code == R_401_UNAUTHORIZED &&
hdr_www_authenticate.is_populated()) ||
(code == R_407_PROXY_AUTH_REQUIRED &&
hdr_proxy_authenticate.is_populated()));
}

void t_response::get_destination(t_ip_port &ip_port) const {
Expand Down