refactor: unify player state into single Status enum#553
Open
refactor: unify player state into single Status enum#553
Conversation
|
theashraf
force-pushed
the
refactor/unified-status-enum
branch
2 times, most recently
from
4771388 to
ad0fa54
Compare
- stop() during Tweening now resets resume_status to Stopped so stale pre-tween status can't linger past a cancel. - Add regression test locking in that pause() during Tweening returns InsufficientCondition and leaves status at Tweening.
theashraf
force-pushed
the
refactor/unified-status-enum
branch
from
6ee4855 to
4ba4613
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_loaded+PlaybackStatewith a singleStatusenum (Idle,Playing,Paused,Stopped,Tweening)status()method instead ofis_playing()/is_paused()/is_stopped()/is_loaded()/is_tweening()Breaking changes (C API)
dotlottie_playback_status→dotlottie_statusdotlottie_is_loadedremovedIdle=0, Playing=1, Paused=2, Stopped=3, Tweening=4Idleis now distinct fromStopped. Previouslydotlottie_playback_statusreturnedStoppedboth when no animation was loaded and when one was loaded but stopped. Consumers that branched onStoppedto mean "not loaded" now receiveIdlefor that case and must be updated.