Skip to content

fix algorithm tuple typo and numpy normed kwarg #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jl33-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix algorithm tuple typo and numpy normed kwarg #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion realtime_decoder/decoder_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ def _init_decoder(self):
config = self._config
rank = self.rank

if config['algorithm'] in ('clusterless_decoder, clusterless_classifier'):
if config['algorithm'] in ('clusterless_decoder', 'clusterless_classifier'):
self._decoder = ClusterlessDecoder(
rank, config,
position.PositionBinStruct(
Expand Down
6 changes: 5 additions & 1 deletion realtime_decoder/encoder_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,14 @@ def get_joint_prob(self, mark):
# print("")
# print(weights)

# `density=` (formerly `normed=`) intentionally omitted: we want the
# raw weighted sum per bin, which is the default behavior. `normed=`
# was removed in NumPy 1.24, which broke this call on any modern
# install.
hist, hist_edges = np.histogram(
a=positions,
bins=self._pos_bin_struct.pos_bin_edges,
weights=weights, normed=False
weights=weights,
)

hist += 0.0000001
Expand Down