feat(helm): replace reloader toggle with generic deploymentAnnotations#3736
Merged
Merged
Conversation
Adds an opt-in `vmArgs` value rendered into a ConfigMap, mounted at /etc/logflare/vm.args, and wired via RELEASE_VM_ARGS. Defaults to a set including `+Q 1048576`, which caps the BEAM's preallocated port table — needed on Kubernetes, where containerd runs pods with nofile=infinity and the VM would otherwise size the table from that (~2GB RSS at boot). Mounted with subPath so it coexists with the cert-files mount under /etc/logflare. A checksum/vm-args pod annotation rolls the Deployment when the args change. Set vmArgs to "" to fall back to the image's baked-in vm.args. Adds helm-unittest coverage.
…ploymentAnnotations Per review on #3728: the `logflare.reloader` boolean hard-coded a Stakater- specific annotation, which is too opinionated for a public chart. Replace it with a generic top-level `deploymentAnnotations` map (mirroring podAnnotations) that renders onto the Deployment's own metadata.annotations. This keeps the chart neutral about the reload mechanism — opt into Reloader with `deploymentAnnotations: { reloader.stakater.com/auto: "true" }` — and fills a real gap: there was no hook for Deployment-level annotations (podAnnotations only reaches the pod template). Updates the helm-unittest cases and README.
Ziinc
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3735 (which is stacked on
feat/helm). Addresses Ziinc's review comment on #3728: thelogflare.reloaderboolean hard-coded a Stakater-specific annotation, too opinionated for a public/community chart.Change
Replaces the
reloadertoggle with a generic top-leveldeploymentAnnotationsmap (mirroringpodAnnotations) rendered onto the Deployment's ownmetadata.annotations.