Skip to content

fix: add back reason to test connection controller, updated test_connection/1 callback #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ziinc merged 8 commits into from
Jul 2, 2026
Merged

fix: add back reason to test connection controller, updated test_connection/1 callback #3624

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1821f1a
fix: add back reason to test connection controller
Ziinc Jun 22, 2026
f8483ba
chore: reduce test_connection error tuple ambiguity
Ziinc Jul 2, 2026
779b7f1
chore: add guard to ensure that QueryError struct is not leaked
Ziinc Jul 2, 2026
2b1e76e
chore: fix compilation errors
Ziinc Jul 2, 2026
0ec566b
chore: adjust SentryAdaptor, PostgresAdaptor, SyslogAdaptor, OtlpAdap…
Ziinc Jul 2, 2026
fe9b576
chore: fix compilation issues
Ziinc Jul 2, 2026
b1760b8
chore: typing issues
Ziinc Jul 2, 2026
5b443e6
chore: failing tests
Ziinc Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/logflare_web/controllers/api/backend_controller.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ defmodule LogflareWeb.Api.BackendController do
conn
|> json(%{connected?: true})

{:error, _reason} ->
{:error, reason} ->
conn
|> json(%{connected?: false})
|> json(%{connected?: false, reason: reason})
Comment thread
Ziinc marked this conversation as resolved.
Outdated
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion test/logflare_web/controllers/api/backend_controller_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ defmodule LogflareWeb.Api.BackendControllerTest do
|> post("/api/backends/#{backend.token}/test")
|> json_response(200)

assert response == %{"connected?" => false}
assert response == %{"connected?" => false, "reason" => "some_reason"}
end

test "returns 404 if backend doesn't exist or doesn't belong to user", %{
Expand Down
Loading