Repository navigation
fix(sdk): cloud=lightning preferring sched-test clusters over baremetal - #59
Merged
Merged
Conversation
Prefer the canonical lightning-baremetal account when multiple MACHINE clusters share the LIGHTNING provider alias, instead of last-writer-wins. Co-authored-by: Cursor <cursoragent@cursor.com>
tchaton
requested review from
ethanwharris,
justusschock and
k223kim
as code owners
July 29, 2026 13:33
Extend the LIGHTNING baremetal preference to AWS, GCP, Lambda, Nebius, and Voltage Park. Keep BYOC preferred for non-global mapping used by data connections. Co-authored-by: Cursor <cursoragent@cursor.com>
tchaton
changed the title
tchaton
changed the title
Covers staging/local environments where prod IDs like lightning-baremetal are absent: mapping and resolve_cloud_account keep the first available account. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
justusschock
approved these changes
Jul 29, 2026
justusschock
enabled auto-merge (squash)
July 29, 2026 13:43
k223kim
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--cloud=<provider>could resolve to an arbitrary account of that provider because provider→account mapping used last-writer-wins when multiple accounts share a tag.LIGHTNING→lightning-baremetalAWS→lightning-public-prodGCP→gcp-lightning-public-prodLAMBDA_LABS→lightning-lambda-prodNEBIUS→lightning-nebius-prodVOLTAGE_PARK→lightning-voltagepark-prodTest plan
pytest tests/api/test_cluster_api.py--cloud=lightningresolves tolightning-baremetal--cloud=aws/gcp/ etc. resolve to the public prod accounts above when present