refactor code for improved readability and consistency - #930
Merged
tchaton merged 7 commits intoSep 29, 2026
Merged
Conversation
deependujha
requested review from
bhimrazy,
dhedey,
pwgardipee and
tchaton
as code owners
September 28, 2026 05:16
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
=====================================
Coverage 82% 82%
=====================================
Files 70 70
Lines 16153 16154 +1
=====================================
+ Hits 13258 13260 +2
+ Misses 2895 2894 -1 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Only a minor documentation nit remains, with no approval-blocking issues.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Refactors optional API defaults for consistency and improves Parquet typing.
Changes:
- Replaces mutable
{}defaults withNone. - Adds explicit Parquet file typing.
- Ignores
uv.lock.
| File | Summary |
|---|---|
src/litdata/utilities/parquet.py |
Updates Parquet option defaults. |
src/litdata/utilities/dataset_utilities.py |
Updates dataset utility defaults. |
src/litdata/streaming/writer.py |
Updates indexing API defaults. |
src/litdata/streaming/reader.py |
Updates reader defaults. |
src/litdata/streaming/item_loader.py |
Updates loader state initialization. |
src/litdata/streaming/downloader.py |
Updates downloader defaults; docstring default needs alignment. |
src/litdata/streaming/dataset.py |
Updates dataset defaults. |
src/litdata/streaming/config.py |
Updates configuration defaults. |
src/litdata/streaming/client.py |
Updates client defaults. |
src/litdata/streaming/cache.py |
Updates cache defaults. |
src/litdata/processing/readers.py |
Adds Parquet file typing. |
.gitignore |
Ignores uv.lock. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tchaton
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Continues work from #837
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃