Skip to content

fix: remove default max token - #59

Merged
k223kim merged 1 commit into
mainfrom
k223kim/fix-max-token-default
Sep 9, 2025
Merged

k223kim merged 1 commit into
mainfrom
k223kim/fix-max-token-default

Conversation

@k223kim

@k223kim k223kim commented Sep 9, 2025

Copy link
Copy Markdown
Collaborator
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

With google gemini models, if max_tokens is set too low, it may result in an empty response. To make it more reliable, this PR removes the default max_tokens value.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov

codecov Bot commented Sep 9, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84%. Comparing base (77c3566) to head (ec54cc7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #59   +/-   ##
==================================
  Coverage    84%   84%           
==================================
  Files         8     8           
  Lines       431   431           
==================================
  Hits        364   364           
  Misses       67    67           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k223kim
k223kim merged commit 83c25ac into main Sep 9, 2025
31 checks passed
@k223kim
k223kim deleted the k223kim/fix-max-token-default branch September 9, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants