Conversation
bhimrazy
requested review from
k223kim,
lianakoleva and
tejapulagam
as code owners
September 24, 2026 13:31
bhimrazy
added this pull request to stack #2849
September 24, 2026 13:31
test_dtensor_basic_op built its reference with torch.compile, which put an inductor Triton launch in front of a test that is about thunder's lowering of the op over a DTensor. On the torch nightly image that launch fails: torch/_inductor/runtime/static_triton_launcher.py:291 RuntimeError: CUDA driver error: invalid argument and the other rank then waits until the 300s process timeout, so the same cause shows up as a crash in one variant and as timeouts in two others. Binding each rank to its device first does not change this; an eager reference fixes all three, as the opinfo tests already use.
bhimrazy
force-pushed
the
bhimrazy/dtensor-eager-reference
branch
from
September 24, 2026 13:44
4d8ab36 to
741efbf
Compare
lianakoleva
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Compares
test_dtensor_basic_opagainst eager instead oftorch.compile, as the opinfo tests in the same file already do.Problem: the test built its reference with
torch.compile, so an inductor Triton launch ran before thunder was reached. On torch nightly that launch fails withCUDA driver error: invalid argument, and the other rank then waits for the 300s process timeout. So one cause shows up as a crash in one variant and as timeouts in two others. The test is about thunder's lowering of the op over a DTensor, not inductor's.Checked on 2× L4 with the
pt_main-devimage: 3 of the 6 variants fail before (11 min, with the timeouts), and all 6 pass after (55s). Binding each rank to its device first doesn't change the result.Related CI:
all-tests.yamldistributedonpt_main-dev: the threetest_dtensor_basic_op_*failures.CI log (
distributed,pt_main-dev, on #2847)Part 14 of the breakdown of #2832.