Skip to content

test(ci): skip the bf16 GPT tests that crash on Windows [10/n] - #2838

Open
bhimrazy wants to merge 1 commit into
bhimrazy/autograd-fwd-tuple-outputfrom
bhimrazy/windows-bf16-skip
Open

bhimrazy wants to merge 1 commit into
bhimrazy/autograd-fwd-tuple-outputfrom
bhimrazy/windows-bf16-skip

Conversation

@bhimrazy

@bhimrazy bhimrazy commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Skips test_litgpt and test_nanogpt (in test_jit_general.py and test_interpreter.py) on Windows.

Problem: running these models in bfloat16 on CPU intermittently kills the Windows test process with an illegal instruction, failing pytester (windows-latest, …) in about half of runs. The crash happens in eager torch, before thunder runs, so pytest can't catch it or retry it:

Windows fatal exception: code 0xc000001d
worker 'gw1' crashed while running 'thunder/tests/test_jit_general.py::test_litgpt'

Fix: a skipif(IS_WINDOWS) with a shared reason in framework.py. The fp32 variants of the same models still run on Windows, and these tests still run on Linux and macOS.

Part 10 of the breakdown of #2832.

@bhimrazy
bhimrazy added this pull request to stack #2837 September 24, 2026 02:56
@bhimrazy
bhimrazy force-pushed the bhimrazy/windows-bf16-skip branch from 3e528fb to cd418d4 Compare September 24, 2026 02:58
@bhimrazy
bhimrazy removed this pull request from stack #2837 September 24, 2026 07:49
@bhimrazy bhimrazy changed the title test(ci): skip the bf16 GPT tests that crash on Windows [3/n] test(ci): skip the bf16 GPT tests that crash on Windows Sep 24, 2026
@bhimrazy
bhimrazy force-pushed the bhimrazy/windows-bf16-skip branch from cd418d4 to 1fbab4d Compare September 24, 2026 11:10
@bhimrazy bhimrazy changed the title test(ci): skip the bf16 GPT tests that crash on Windows test(ci): skip the bf16 GPT tests that crash on Windows [10/n] Sep 24, 2026
@bhimrazy
bhimrazy changed the base branch from bhimrazy/drop-unused-torchaudio to bhimrazy/autograd-fwd-tuple-output September 24, 2026 11:11
@bhimrazy
bhimrazy added this pull request to stack #2849 September 24, 2026 11:12
@bhimrazy
bhimrazy force-pushed the bhimrazy/windows-bf16-skip branch from 1fbab4d to 0b5b440 Compare September 24, 2026 12:29
Running these models in bfloat16 on CPU intermittently kills the Windows
test process with an illegal instruction (0xc000001d). It happens in
eager torch, before thunder runs, so pytest cannot catch it and the whole
xdist worker dies.

The fp32 variants of the same models still run on Windows, and these
still run on Linux and macOS.
@bhimrazy
bhimrazy force-pushed the bhimrazy/windows-bf16-skip branch from 0b5b440 to 96a8739 Compare September 24, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants