Skip to content

Remove F405 from Ruff ignore list #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arubittu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove F405 from Ruff ignore list #2828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ ignore = [
# TODO(crcrpar): Resolves the following ignores as these are added while enabling ruff check in pre-commit
"F821", # https://docs.astral.sh/ruff/rules/undefined-name/
"E402", # https://docs.astral.sh/ruff/rules/module-import-not-at-top-of-file/
"F405", # https://docs.astral.sh/ruff/rules/undefined-local-with-import-star-usage/
"E712", # https://docs.astral.sh/ruff/rules/true-false-comparison/
"E721", # https://docs.astral.sh/ruff/rules/type-comparison/
]
Expand Down
9 changes: 8 additions & 1 deletion thunder/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,14 @@
]


from thunder.__about__ import * # noqa: F403
from thunder.__about__ import (
__author__ as __author__,
__author_email__ as __author_email__,
__copyright__ as __copyright__,
__docs__ as __docs__,
__homepage__ as __homepage__,
__version__ as __version__,
)


# TODO maybe move these aliases to the core language?
Expand Down
9 changes: 9 additions & 0 deletions thunder/core/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,16 @@
import thunder.core.dtypes as dtypes
from thunder.core.pytree import tree_flatten, tree_unflatten, tree_map
from thunder.core.proxies import Proxy, NumberProxy, TensorProxy, variableify, CONSTRAINT, Variable
from thunder.core.baseutils import (
BoundSymbolInterface,
TensorProxyInterface,
check,
check_type,
check_valid_length,
check_valid_shape,
)
from thunder.core.baseutils import * # noqa: F403
from thunder.core.codeutils import SigInfo
from thunder.core.codeutils import * # noqa: F403
from thunder.core.trace import TraceCtx, tracectx
import thunder.core.prims as prims
Expand Down