Set TensorProxy shape's history to None if tensor's history is unavailable - #2755
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an AssertionError that occurs when creating TensorProxy objects with dynamic shapes for DTensors that lack history information. The fix ensures that when a tensor's history is unavailable, the shape's IntegerProxy objects are created with history=None instead of attempting to construct a ProvenanceRecord from a None value.
- Modified the
tensorproxyfunction to conditionally create shape provenance records only when history is available - Added the first test case for DTensor with dynamic shapes to ensure proper caching behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| thunder/core/proxies.py | Added conditional logic to handle None history when creating shape IntegerProxy objects for symbolic values |
| thunder/tests/distributed/test_dtensor.py | Added test case for DTensor.from_local with symbolic values caching to verify dynamic shape handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kshitij12345
approved these changes
Nov 19, 2025
kshitij12345
left a comment
kshitij12345
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks @shino16
KaelanDt
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix the AssertionError reported in #2677 (comment).
See #2746 (comment) for the discussion on correctness.
I added a test for this, which was the first test related to DTensors with dynamic shapes.