Fix benchmark_inference.py segfault and superficial errors with multiple devices - #2745
Closed
shino16 wants to merge 4 commits into
Closed
Fix benchmark_inference.py segfault and superficial errors with multiple devices#2745shino16 wants to merge 4 commits into
benchmark_inference.py segfault and superficial errors with multiple devices#2745shino16 wants to merge 4 commits into
Conversation
shino16
force-pushed
the
fix-2677-segfault
branch
from
November 17, 2025 21:01
2215cf3 to
d05dac5
Compare
This was referenced Nov 18, 2025
[Experimental] Insert
prims.shape to ensure NumberProxy is materialized for all dynamic shapes
#2746
Closed
Collaborator
|
Solving #2677 completely is going to blow this PR up into a monster, touching lots of files. I think it would be better to fix each issue individually. It will make it easier to choose targeted reviewers for each change. This will also potentially save time later, if an issue pops up and bisection is used to find the culprit commit. So, let's just start with the seg fault fix. |
Collaborator
Author
|
Your suggestion makes sense, I'll submit separate small PRs. And thank you for your reviews in #2746! @beverlylytle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_call_dispatchuse__get__(slf, type(slf))instead of__get__(slf), working around a CPython segfault (python/cpython#132747). From Python 3.13.3 this workaround will no longer be necessary, but I think we can keep it anyway.TensorProxy.shape's provenance only when the tensor's history exists, so that incomplete provenance record will not be created. This fixes theAssertionErrorin mentioned in #2677 (comment).thunder/core/update_aliases.pyskip numel checks (introduced in #2716) when relevant shapes are dynamic.Multi-device support of
benchmark_inference.pyis still incomplete. Refer to #2677 for progress.