app: post agent findings to the PR — adopt as review comments#36
Merged
Conversation
An 'Add to review' action on finding rows (FindingsPanel + Briefing) converts a finding into a local comment at its anchor, with the agent's severity/title/rationale and an honest provenance footer. Posting to the human's PR still rides the existing guarded Mirror / Submit-review flows — two deliberate clicks between agent output and GitHub (§9). Idempotent: an adopted finding shows Added and cannot double-post.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On a review-request PR you can now get the agent's findings onto the author's PR: each finding row (Diff-tab findings panel and the Briefing) gains Add to review, which drafts a local comment at the finding's exact line/side with the severity, title, rationale, and a provenance footer (
_Advisory finding from the reviewer's pre-review agent, adopted by the reviewer._).Posting stays behind the existing guarded flows — Submit review (inline comments via the reviews API, per-line validated) or Mirror — so agent output reaches GitHub only after two deliberate human actions (§9: adoption click + confirmed submit). No new GitHub surface; adopted comments are ordinary local comments (editable, dismissable, ephemeral per §0.4), and on authored PRs the same action feeds the rework dispatch instead.
Idempotent by anchor+title matching: adopted findings show "Added ✓" and can't double-post. The affordance appears only while the gate is InReview (same rule as commenting) and only for line-anchored findings.
Verified
tscclean ·vitest398 (+7: comment-body format, adoption matching incl. side/line/plan-anchor negatives, render tests for the button/Added/hidden states) ·vite buildok. Frontend-only — reusesadd_comment+submit_reviewunchanged.🤖 Generated with Claude Code