Phase E — the teammate half of the job#16
Merged
Conversation
…Linear intent fetch_conversation merges reviews/review-comments/issue-comments (three concurrent gh reads, fixture-tested parsers, state-only approvals kept); submit_github_review records last_reviewed_sha; get_teammate_interdiff compares it to the pinned head; Linear descriptions seed review intent and capped plan-issue gists (goldens byte-identical). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Read-only GitHub conversation context for review-requested PRs (state- aware labels, plain-text bodies, external links); the interdiff toggle gains a teammate source driven by last_reviewed_sha vs pinned head with a 'pushed since your review' header note. Authored (dispatch_snapshot) and teammate paths are mutually exclusive by construction. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A stalled Linear response was the one un-timed await in plan generation and kickoff; errors already degrade gracefully, now hangs do too. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (ROADMAP Phase E)
gh apireads, fixture-tested parsers, ghost-user tolerance, plain-text rendering of all untrusted content. Conversation lives on a separate model from ephemeral comments (§0.4 by design: the gate never clears it, and it can never feed prompts — reviewer-verified zero consumers).submit_github_reviewrecordslast_reviewed_sha; when a teammate pushes past it, the interdiff toggle offers "Since your review" viagh compare, with a header note. Authored (dispatch-snapshot) and teammate paths are disjoint by construction.Review.body) and capped 300-char gists in plan prompts — with the missing plan-issue list built properly (non-blocking, 15s-bounded Linear fetch; goldens byte-identical).Review round
Reviewer: ship-ready, zero critical/major. Advisory fixed here: Linear API calls bounded with a 15s timeout (was the one un-timed await). Remaining advisories documented (FRAGILE string-match on the benign no-new-commits error; ISO-sort assumption noted in-code).
Verified
cargo fmt/clippy -D warnings/test --all (458+) · tsc strict · vitest 201 · vite build · reviewer pass.
🤖 Generated with Claude Code