Skip to content

add Windows and macOS to build matrix, fix cross-platform issues #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sreeya12 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Draft

add Windows and macOS to build matrix, fix cross-platform issues #1547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@ permissions:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
matrix:
java: [21, 24, 25, '26-ea']
os: [ubuntu-latest, windows-latest, macos-latest]
java: [21, 24, 25, '26-ea']
name: Build with Java ${{ matrix.java }}
steps:
- uses: actions/checkout@v5
Expand All @@ -22,6 +23,7 @@ jobs:
java-version: ${{ matrix.java }}

- name: Check Maven version and directory contents
shell: bash
run: |
mvn -v
echo "** ls **"
Expand Down
3 changes: 2 additions & 1 deletion openpdf-core/src/test/java/org/openpdf/text/pdf/fonts/FontTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
package org.openpdf.text.pdf.fonts;

import org.junit.jupiter.api.Assumptions;
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
Expand Down Expand Up @@ -84,6 +84,7 @@ void testStyleSettingByPredicate(int style) {
@ParameterizedTest(name = "Style {0}")
@MethodSource("getStyles")
void testFontStyleOfStyledFont(int style) {
Assumptions.assumeFalse(System.getProperty("os.name").toLowerCase().contains("mac"), "Font not available on macOS");
final Font font = FontFactory.getFont(FONT_NAME_WITH_STYLES, DEFAULT_FONT_SIZE, style);

// For the font Courier, there is no Courier-Underline or Courier-Strikethrough font available.
Expand Down