fix(plugin-fees): guard replicas when autoscaling enabled - #1764
Open
guimoreirar wants to merge 1 commit into
Open
fix(plugin-fees): guard replicas when autoscaling enabled#1764guimoreirar wants to merge 1 commit into
guimoreirar wants to merge 1 commit into
Conversation
The plugin-fees Deployment template(s) (fees) rendered spec.replicas
unconditionally even with autoscaling.enabled=true. With an HPA active,
kube-controller-manager owns .spec.replicas via the scale subresource, so
Server-Side Apply (Rancher/Fleet, ArgoCD) rejects helm upgrade with a
field-ownership conflict on .spec.replicas.
Wrap replicas in {{- if not .Values.<component>.autoscaling.enabled }} so the
field is omitted when the HPA owns it. Same class of fix as plugin-br-pix-indirect-btg.
X-Lerian-Ref: 0x1
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe fees Deployment template now conditionally renders ChangesFees Deployment scaling
Possibly related PRs
✨ Finishing Touches✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Midaz Pull Request Checklist
Pull Request Type
Summary
Fixes a Server-Side Apply field-ownership conflict on
.spec.replicas— the same class of bug as #1760 (plugin-br-pix-indirect-btg), found by a repo-wide sweep.The plugin-fees Deployment template(s) (
fees) renderedspec.replicasunconditionally, even withautoscaling.enabled: true. When the chart's HPA is active,kube-controller-managerowns.spec.replicasvia thescalesubresource, so under SSA (Rancher/Fleet, ArgoCD) Helm and the HPA contend for the field:Fix
Wrap
replicasin{{- if not .Values.<component>.autoscaling.enabled }}so it is omitted whenever that component's HPA owns it. Standard HPA-chart practice (Bitnami, kube-prometheus-stack).Testing
helm templateverified:autoscaling.enabled=true→spec.replicasabsent;false→ declaredreplicaCount.Checklist
Chart.yamlversion,CHANGELOG.md, or the README version matrix (CI owns these;fix→ patch bump).Additional Notes
Part of a coordinated sweep of the HPA/SSA
replicasbug across charts.lerian-common_deployment.tpldoes not emitreplicas, so lib-based charts are unaffected.