feat(plugin-access-manager): productize on lerian-common library (no regression) - #1745
Open
guimoreirar wants to merge 1 commit into
Open
feat(plugin-access-manager): productize on lerian-common library (no regression)#1745guimoreirar wants to merge 1 commit into
guimoreirar wants to merge 1 commit into
Conversation
…regression) Adopt lerian-common helpers where render-equivalent: hpa/pdb (auth, auth-backend, identity), service (identity, auth-backend), ingress (auth, identity), and the OTEL block (auth, identity configmaps) via otel.envFlat. Bespoke surfaces stay native (deployments, casdoor configmap, migration/ init-user Jobs, provider secrets, dual-port auth service) — access-manager is the auth provider, so no PLUGIN_AUTH consumer helper is used. Adds the lerian-common-helm dependency (file://../lerian-common, >=1.0.0 <2.0.0). Render byte-identical to main (empty diff).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (13)
📝 WalkthroughWalkthroughThe chart adds the shared ChangesShared helper migration
Possibly related PRs
✨ Finishing Touches✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Productizes
charts/plugin-access-manager/on the lerian-common library — render byte-identical to main (empty diff, verified with the CI sample values).What changed (helper-ized, render-clean)
lerian-common.hpa/.pdblerian-common.servicelerian-common.ingresslerian-common.otel.envFlatlerian-common-helmdependency (file://../lerian-common,>=1.0.0 <2.0.0).Left native (bespoke — no render-equivalent helper)
Deployments (custom initContainers/probes/casdoor overrides), casdoor beego configmap, migration + init-user Jobs, provider secrets, dual-port
authservice. access-manager is the auth provider, so thePLUGIN_AUTHconsumer helper is intentionally NOT used;MULTI_TENANT_ENABLEDtoggle stays native (no lib multi-tenant block here); no SD_* block exists.Verification
0 violations.Dependency
Uses
file://to the in-repolerian-common. The render-gate resolvesfile://local deps via thematerializeLocalDependenciesvalidator step introduced in #1741 — so the render-gate check here will pass once #1741 merges (bringing that validator step to main).helm dependency build+helm templatesucceed at the real repo layout; strict is green.Depends on #1742 (merged — helpers on main) and #1741 (validator step).