Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9496d6c748
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| helm upgrade --install \ | ||
| "${RELEASE_NAME}" \ | ||
| "${PROJECT_DIR}/deploy/k3s/charts/livid-bot" \ |
There was a problem hiding this comment.
Include the Helm chart path used by deploy.sh
The deployment script hardcodes "${PROJECT_DIR}/deploy/k3s/charts/livid-bot", but this commit does not add that chart directory (repo search only finds references in docs/scripts). In this state, helm upgrade --install fails immediately with a missing chart path, so both deploy.sh and cutover.sh cannot run in any environment.
Useful? React with 👍 / 👎.
Summary
Testing
helm lint deploy/k3s/charts/livid-bothelm template deploy/k3s/charts/livid-bot --namespace default | kubectl apply --dry-run=server -n default -f -bash -n deploy/k3s/bin/*.shgit diff --checkThis branch has already been used for the live k3s cutover.