Skip to content

added new error handling to date and datetime #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oroth8 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

added new error handling to date and datetime #133

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2e8d994
added new error handling to date and datetime
oroth8 Aug 24, 2022
82e49c5
added more tests
oroth8 Aug 24, 2022
8e36442
raise based on message
oroth8 Aug 24, 2022
f4cd054
refactor rescue to still raise an argument error even though it is no…
oroth8 Dec 14, 2022
b5333ea
bump minor version
oroth8 Dec 14, 2022
217ffe7
Merge branch 'main' into return-decanter-exception-for-date-and-datet…
oroth8 Apr 7, 2025
7e69ed1
rescue Date::Error instead and make sure errors are not swallowed
oroth8 Apr 7, 2025
99304cc
bump version to 5.1.0
oroth8 Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/decanter/exceptions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ class Error < StandardError; end
class UnhandledKeysError < Error; end
class MissingRequiredInputValue < Error; end
class ParseError < Error; end
class ValueFormatError < Error; end
end
4 changes: 4 additions & 0 deletions lib/decanter/parser/date_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ class DateParser < ValueParser
raise Decanter::ParseError.new 'Expects a single value' if val.is_a? Array
next if (val.nil? || val === '')
parse_format = options.fetch(:parse_format, '%m/%d/%Y')
begin
::Date.strptime(val, parse_format)
rescue ArgumentError => e
Comment thread
oroth8 marked this conversation as resolved.
Outdated
raise Decanter::ValueFormatError.new 'invalid Date value for format' if e.message == "invalid date"
Comment thread
oroth8 marked this conversation as resolved.
Outdated
end
end
end
end
Expand Down
4 changes: 4 additions & 0 deletions lib/decanter/parser/datetime_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ class DateTimeParser < ValueParser
raise Decanter::ParseError.new 'Expects a single value' if val.is_a? Array
next if (val.nil? || val === '')
parse_format = options.fetch(:parse_format, '%m/%d/%Y %I:%M:%S %p')
begin
::DateTime.strptime(val, parse_format)
rescue ArgumentError => e
raise Decanter::ValueFormatError.new 'invalid DateTime value for format' if e.message == "invalid date"
end
end
end
end
Expand Down
9 changes: 8 additions & 1 deletion spec/decanter/parser/date_parser_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,14 @@
context 'with an invalid date string' do
it 'raises an Argument Error' do
expect { parser.parse(name, '2-21-1990') }
.to raise_error(ArgumentError, 'invalid date')
.to raise_error(Decanter::ValueFormatError, 'invalid Date value for format')
end
end

context 'with a invalid date string and custom format' do
it 'raises an Argument Error' do
expect { parser.parse(name, '2-21-1990', parse_format: '%d-%m-%Y') }
.to raise_error(Decanter::ValueFormatError, 'invalid Date value for format')
end
end

Expand Down
9 changes: 8 additions & 1 deletion spec/decanter/parser/datetime_parser_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,14 @@
context 'with an invalid date string' do
it 'raises an Argument Error' do
expect { parser.parse(name, '2-21-1990') }
.to raise_error(ArgumentError, 'invalid date')
.to raise_error(Decanter::ValueFormatError, 'invalid DateTime value for format')
end
end

context 'with a invalid date string and custom format' do
it 'raises an Argument Error' do
expect { parser.parse(name, '2-21-1990', parse_format: '%d-%m-%Y') }
.to raise_error(Decanter::ValueFormatError, 'invalid DateTime value for format')
end
end

Expand Down