Skip to content

AK: Relax ensure_capacity assertion to allow allocator-rounded capacity #8897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
officialasishkumar wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

AK: Relax ensure_capacity assertion to allow allocator-rounded capacity #8897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Tests/AK/TestJSON.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,10 @@ TEST_CASE(json_array_ensure_capacity)
auto array = setup_json_array();
size_t new_capacity { 16 };
array.ensure_capacity(new_capacity);
EXPECT_EQ(array.values().capacity(), new_capacity);
// The allocator may round up the capacity to a larger value that is
// efficient for its internal bookkeeping (e.g. mimalloc's mi_good_size),
// so we only require that the resulting capacity is at least new_capacity.
EXPECT_GE(array.values().capacity(), new_capacity);
}

TEST_CASE(json_array_for_each)
Expand Down
Loading