LibWeb: Paint backgrounds for table column and column group elements#8887
Open
tcl3 wants to merge 2 commits intoLadybirdBrowser:masterfrom
Open
LibWeb: Paint backgrounds for table column and column group elements#8887tcl3 wants to merge 2 commits intoLadybirdBrowser:masterfrom
tcl3 wants to merge 2 commits intoLadybirdBrowser:masterfrom
Conversation
This keeps background sizing, positioning, and painting in one place while allowing later commits to reuse it for table part backgrounds, where the positioning area and paint clip come from different boxes.
During table layout, we now build a mapping from column index to the column and column group layout nodes. We then transfer this to the table paintable, so it is available at paint time.
tcl3
force-pushed
the
libweb_table_column_background_painting
branch
from
4cd9120 to
59c6b06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During table layout, we now build a mapping from column index to the column and column group layout nodes. We then transfer this to the table paintable, so it is available at paint time.