LibWeb: Add basics of PermissionsAPI#8874
Draft
NiccoloAntonelliDziri wants to merge 1 commit intoLadybirdBrowser:masterfrom
Draft
LibWeb: Add basics of PermissionsAPI#8874NiccoloAntonelliDziri wants to merge 1 commit intoLadybirdBrowser:masterfrom
NiccoloAntonelliDziri wants to merge 1 commit intoLadybirdBrowser:masterfrom
Conversation
NiccoloAntonelliDziri
force-pushed
the
permission
branch
6 times, most recently
from
60917cc to
9a32cf0
Compare
This adds the basic infrastructure for the Permissions API, including the `Permissions` and `PermissionStatus` interfaces. The API is exposed via `navigator.permissions` on both `Window` and `WorkerGlobalScope`. - `is_permission_supported` is hardcoded to return false. - The `query()` method checks for a secure context but rejects all queries since no powerful features are supported yet. Passes a few more subtests in `permissions/`. https://wpt.live/permissions/idlharness.any.html https://wpt.live/permissions/idlharness.any.worker.html https://wpt.live/permissions/edge-cases.https.html This one behaves differently because now the `query` property is defined. And the last subtest passes for the wrong reason. "Querying "fullscreen" permission with "allowWithoutGesture" false is unsupported" but in fact everything is currently unsupported. https://wpt.live/fullscreen/api/permission.tentative.https.html
NiccoloAntonelliDziri
force-pushed
the
permission
branch
from
9a32cf0 to
45e2844
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the basic infrastructure for the Permissions API, including the
PermissionsandPermissionStatusinterfaces. The API is exposed vianavigator.permissionson bothWindowandWorkerGlobalScope.is_permission_supportedis hardcoded to return false.query()method checks for a secure context but rejects all queries since no powerful features are supported yet.