Continue enhancing SQL protections#3026
Open
labkey-jeckels wants to merge 2 commits into
Open
Conversation
labkey-matthewb
approved these changes
Jun 1, 2026
Contributor
There was a problem hiding this comment.
This fb isn't building on TC right now so I can't find the exact test, but I believe there's an ETL count check in a test in a different repo that runs in a daily suite. Maybe this one in dataintegration. If you add another ETL it has to be updated.
Contributor
Author
Yup. I've been annoyed (probably not as often as you!) about the many repos needing to be touched for changes like this. I bumped the count in the related PR: |
labkey-martyp
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Robust SQL generation is important. Code cleanup and consolidation is nice too.
Related Pull Requests
Changes