Skip to content

SQL Server to Postgres Migration Fixes #7468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-martyp wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

SQL Server to Postgres Migration Fixes #7468

Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
09e2715
Don't do the case statement when casting boolean value.
labkey-martyp Mar 1, 2026
88e7a01
Merge remote-tracking branch 'origin/develop' into fb_query_validation
labkey-bpatel Mar 8, 2026
42a9e64
timestampdiff2
labkey-martyp Mar 9, 2026
d054412
Better calculation of year, month, quarter
labkey-martyp Mar 9, 2026
25aa55b
Handle type overflow
labkey-martyp Mar 9, 2026
3b2b28b
Simplify with AGE. Fix test case.
labkey-martyp Mar 9, 2026
cb2aaee
More negative value tests
labkey-martyp Mar 9, 2026
7f06f3e
Merge branch 'develop' into fb_query_validation
labkey-martyp Mar 10, 2026
e0319b3
Merge branch 'develop' into fb_query_validation
labkey-martyp Mar 11, 2026
e7ee897
Test doesn't work on sql server
labkey-martyp Mar 11, 2026
bd0ef42
Merge branch 'develop' into fb_query_validation
labkey-martyp Mar 24, 2026
dc4bd61
age_in_days
labkey-martyp Mar 31, 2026
c070adc
Migration service update
labkey-martyp Mar 31, 2026
fb096f7
Merge branch 'develop' into fb_query_validation
labkey-martyp Apr 3, 2026
dc9a8e7
Update test type
labkey-martyp Apr 3, 2026
80a5e5b
CR feedback
labkey-martyp Apr 8, 2026
0fe28f9
remove timestampdiff2
labkey-martyp Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion query/src/org/labkey/query/sql/QuerySelect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2264,7 +2264,9 @@ SQLFragment getInternalSql()
QExpr expr = getResolvedField();

// NOTE SqlServer does not like predicates (A=B) in select list, try to help out
if (expr instanceof QMethodCall && expr.getJdbcType() == JdbcType.BOOLEAN && b.getDialect().isSqlServer())
// Exclude CAST/CONVERT expressions — they produce BIT values, not boolean predicates
if (expr instanceof QMethodCall mc && mc.getJdbcType() == JdbcType.BOOLEAN && b.getDialect().isSqlServer()
&& !(mc.getMethod(b.getDialect()) instanceof Method.ConvertInfo))
{
b.append("CASE WHEN (");
expr.appendSql(b, _query);
Expand Down