Make Tiny Notes Easier to Move#8386
Merged
Merged
Conversation
regulus79
commented
May 14, 2026
| // clicked at the "tail" of the note? | ||
| if( pos_ticks * m_ppb / TimePos::ticksPerBar() > | ||
| m_currentNote->endPos() * m_ppb / TimePos::ticksPerBar() - RESIZE_AREA_WIDTH | ||
| if(x + m_currentPosition * m_ppb / TimePos::ticksPerBar() > |
Member
Author
There was a problem hiding this comment.
FYI I changed this from comparing the mouse position in ticks to comparing the mouse position in pixels, since at high zoom levels, ticks get very wide, and they don't provide enough resolution.
messmerd
reviewed
May 14, 2026
| } | ||
|
|
||
|
|
||
| int PianoRoll::resizeGripWidth(tick_t noteLength) const |
Member
There was a problem hiding this comment.
Given how this is used, you could probably change the parameter to const Note& note and then call note.length() inside this function. That would make call sites a little nicer.
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
rubiefawn
approved these changes
May 15, 2026
rubiefawn
added
enhancement
gui
needs testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentially the same fix as #8385, but for notes in the Piano Roll.
Before:
2026-05-13.14-13-01.mp4
After:
2026-05-13.14-09-29.mp4