Skip to content

Fix Clips Being Hard to Move When Zoomed Out #8385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
regulus79 wants to merge 3 commits into
base: master
Choose a base branch
from
+25 −8
Open

Fix Clips Being Hard to Move When Zoomed Out #8385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76f5c41
Initial fix
regulus79 May 13, 2026
aaf0834
Fix warning
regulus79 May 13, 2026
5ae4903
Formatting and constexpr
regulus79 May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion include/ClipView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public slots:
bool unquantizedModHeld( QMouseEvent * me );
TimePos quantizeSplitPos(TimePos);

float pixelsPerBar();
float pixelsPerBar() const;


DataFile createClipDataFiles(const QVector<ClipView *> & clips) const;
Expand Down Expand Up @@ -234,6 +234,13 @@ protected slots:
TimePos draggedClipPos( QMouseEvent * me );
int knifeMarkerPos( QMouseEvent * me );
void setColor(const std::optional<QColor>& color);

/**
* @returns the width of a note's resize area in pixels.
* @note When zoomed in, this is a constant pixel value, but when zoomed far out,
* it is a fraction of the clip width.
*/
int resizeGripWidth() const;

//! Returns whether the user can left-resize this clip so that the start of the clip bounds is before the start of the clip content.
virtual bool isResizableBeforeStart() { return true; };
Expand Down
24 changes: 17 additions & 7 deletions src/gui/clips/ClipView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,10 @@ namespace lmms::gui
{


/*! The width of the resize grip in pixels
*/
const int RESIZE_GRIP_WIDTH = 8;
//! The default width of the resize grip in pixels
constexpr int RESIZE_GRIP_WIDTH = 8;
//! The maximum fraction of the clip width that the resize grip is allowed to take up
constexpr float RESIZE_GRIP_MAX_WIDTH_FRACTION = 0.1f;


/*! A pointer for that text bubble used when moving segments, etc.
Expand Down Expand Up @@ -397,6 +398,15 @@ void ClipView::setColor(const std::optional<QColor>& color)
Engine::getSong()->setModified();
}


int ClipView::resizeGripWidth() const
{
const int clipWidth = m_clip->length() * pixelsPerBar() / TimePos::ticksPerBar();
return std::min(RESIZE_GRIP_WIDTH, static_cast<int>(std::round(RESIZE_GRIP_MAX_WIDTH_FRACTION * clipWidth)));
}



/*! \brief Change the ClipView's display when something
* being dragged enters it.
*
Expand Down Expand Up @@ -488,7 +498,7 @@ void ClipView::updateCursor(QMouseEvent * me)

// If we are at the edges, use the resize cursor
if (!me->buttons() && m_clip->manuallyResizable() && !isSelected()
&& ((posX > width() - RESIZE_GRIP_WIDTH) || (posX < RESIZE_GRIP_WIDTH)))
&& ((posX > width() - resizeGripWidth()) || (posX < resizeGripWidth())))
{
setCursor(Qt::SizeHorCursor);
}
Expand Down Expand Up @@ -661,12 +671,12 @@ void ClipView::mousePressEvent( QMouseEvent * me )
m_action = Action::Move;
setCursor( Qt::SizeAllCursor );
}
else if (pos.x() >= width() - RESIZE_GRIP_WIDTH)
else if (pos.x() >= width() - resizeGripWidth())
{
m_action = Action::Resize;
setCursor( Qt::SizeHorCursor );
}
else if (pos.x() < RESIZE_GRIP_WIDTH)
else if (pos.x() < resizeGripWidth())
{
m_action = Action::ResizeLeft;
setCursor( Qt::SizeHorCursor );
Expand Down Expand Up @@ -1255,7 +1265,7 @@ void ClipView::toggleSelectedAutoResize()
*
* \return the number of pixels per bar.
*/
float ClipView::pixelsPerBar()
float ClipView::pixelsPerBar() const
{
return m_trackView->trackContainerView()->pixelsPerBar();
}
Expand Down
Loading