Fix length of non-beat clips in the pattern editor

src/core/AutomationClip.cpp

@@ -197,6 +197,12 @@ void AutomationClip::updateLength()
 	// checks if it has been resized from either direction.
 	if (getAutoResize())
 	{
+		if ( m_autoTrack != nullptr && m_autoTrack->trackContainer() == Engine::patternStore() )
+		{
+			// If inside a pattern, the clip is always the lenght of it.
+			changeLength(TimePos::ticksPerBar() * Engine::patternStore()->lengthOfPattern(m_autoTrack->getClipNum(this)));
+			return;
+		}
 		// Using 1 bar as the min length for an un-resized clip. 
 		// This does not prevent the user from resizing the clip to be less than a bar later on.
 		changeLength(std::max(TimePos::ticksPerBar(), static_cast<tick_t>(timeMapLength())));

src/core/PatternStore.cpp

@@ -89,7 +89,7 @@ bar_t PatternStore::lengthOfPattern(int pattern) const
 	for (Track * t : tl)
 	{
 		// Don't create Clips here if they don't exist
-		if (pattern < t->numOfClips())
+		if (pattern < t->numOfClips() && t->type() == Track::Type::Instrument)
 		{
 			maxLength = std::max(maxLength, t->getClip(pattern)->length());
 		}

src/core/SampleClip.cpp

@@ -27,6 +27,7 @@
 #include <QDomElement>
 #include <QFileInfo>
 
+#include "PatternStore.h"
 #include "PathUtil.h"
 #include "SampleClipView.h"
 #include "SampleTrack.h"
@@ -227,6 +228,11 @@ void SampleClip::updateLength()
 	// If the clip has already been manually resized, don't automatically resize it.
 	if (getAutoResize())
 	{
+		if (getTrack()->trackContainer() == Engine::patternStore())
+		{
+			changeLength(TimePos::ticksPerBar() * Engine::patternStore()->lengthOfPattern(getTrack()->getClipNum(this)));
+			return;
+		}
 		changeLength(sampleLength());
 		setStartTimeOffset(0);
 	}

src/gui/clips/AutomationClipView.cpp

@@ -265,7 +265,7 @@ void AutomationClipView::paintEvent( QPaintEvent * )
 	// pixels per bar
 	const float ppb = fixedClips() ?
 			( parentWidget()->width() - 2 * BORDER_WIDTH )
-				/ (float) m_clip->timeMapLength().getBar() :
+				/ (float) m_clip->length().getBar() :
 								pixelsPerBar();
 
 	const auto min = m_clip->firstObject()->minValue<float>();

src/gui/editors/PatternEditor.cpp

@@ -216,11 +216,14 @@ void PatternEditor::updateMaxSteps()
 	m_maxClipLength = 0;
 	for (const auto& track : tl)
 	{
-		if (track->type() == Track::Type::Instrument)
+		auto clip = track->getClip(m_ps->currentPattern());
+		if (track->type() == Track::Type::Automation || track->type() == Track::Type::Sample)
 		{
-			auto mClip = static_cast<MidiClip*>(track->getClip(m_ps->currentPattern()));
-			m_maxClipLength = std::max(m_maxClipLength, static_cast<tick_t>(mClip->length()));
+			// The length of automation and sample clips is updated here.
+			// "Why here ?" will you ask. The answer is: Because.
+			clip->updateLength();
 		}
+		m_maxClipLength = std::max(m_maxClipLength, static_cast<tick_t>(clip->length()));
 	}
 	updatePixelsPerBar();
 }

src/tracks/MidiClip.cpp

@@ -128,7 +128,7 @@ void MidiClip::updateLength()
 	// If the clip hasn't already been manually resized, automatically resize it.
 	if (getAutoResize())
 	{
-		if (m_clipType == Type::BeatClip)
+		if (m_instrumentTrack->trackContainer()->type() == TrackContainer::Type::Pattern)
 		{
 			changeLength(beatClipLength());
 			updatePatternTrack();